MapCacheLRU::has called with invalid key. Must be string or integer.
Closed, ResolvedPublic

Description

From Fatal-Monitor immediately after all wikis to 1.32.0-wmf.14:

[{exception_id}] {exception_url} UnexpectedValueException from line 144 of /srv/mediawiki/php-1.32.0-wmf.14/includes/libs/MapCacheLRU.php: MapCacheLRU::has called with invalid key. Must be string or integer.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2018, 6:16 PM

Change 448095 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[operations/mediawiki-config@master] Revert "all wikis to 1.32.0-wmf.14"

https://gerrit.wikimedia.org/r/448095

zeljkofilipin triaged this task as Unbreak Now! priority.Jul 26 2018, 6:22 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJul 26 2018, 6:22 PM

Change 448095 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "all wikis to 1.32.0-wmf.14"

https://gerrit.wikimedia.org/r/448095

Tgr added a subscriber: Tgr.Jul 26 2018, 6:25 PM

Seems like title parsing broke for URLs which contain nothing but a curid. rMW3d990d17a031: Convert Title::getTitleCache() to using MapCacheLRU (again) is obviously related but it seems like this would throw even without that patch.

Imarlier assigned this task to aaron.Jul 26 2018, 6:29 PM
Tgr added a comment.Jul 26 2018, 6:30 PM

...except that the parent catches MalformedTitleException but not UnexpectedValueException.

Change 448097 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Handle $title === null in Title::newFromText

https://gerrit.wikimedia.org/r/448097

Change 448107 had a related patch set uploaded (by Aaron Schulz; owner: Gergő Tisza):
[mediawiki/core@wmf/1.32.0-wmf.14] Handle $title === null in Title::newFromText

https://gerrit.wikimedia.org/r/448107

Change 448097 merged by jenkins-bot:
[mediawiki/core@master] Handle $title === null in Title::newFromText

https://gerrit.wikimedia.org/r/448097

Change 448107 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.14] Handle $title === null in Title::newFromText

https://gerrit.wikimedia.org/r/448107

Mentioned in SAL (#wikimedia-operations) [2018-07-26T21:32:59Z] <tgr@deploy1001> Synchronized php-1.32.0-wmf.14/includes/Title.php: SWAT T200456: Handle $title === null in Title::newFromText (duration: 00m 57s)

Tgr closed this task as Resolved.Jul 26 2018, 9:34 PM