Maniphest T200491

External links inside ReferenceDrawer do not show the external link icon
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 27 2018, 2:02 AM

Description

Visit http://reading-web-staging.wmflabs.org/wiki/Copenhagen
Click a reference link [6]
See reference drawer

Screen Shot 2018-07-27 at 10.00.51 AM.png (182×568 px, 50 KB)

The link inside the reference drawer does not have an external link icon. Should it?

With icon:

Screen Shot 2018-07-27 at 10.02.31 AM.png (156×545 px, 30 KB)

Developer notes

It looks like this is intentional due to the rule

background-image: none;

Trivial to restore icons - remove this line.

QA steps

Can be tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein or http://reading-web-staging.wmflabs.org/wiki/Albert_Einstein

Details

	Subject	Repo	Branch	Lines +/-
	Add external link icon to external links in ReferenceDrawer	mediawiki/extensions/MobileFrontend	master	+0 -3

Customize query in gerrit

Related Objects

Mentioned In: T190549: Differentiate between internal, sister-wiki, interwiki, and external links visually

Event Timeline

Jdlrobson created this task.Jul 27 2018, 2:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2018, 2:02 AM

Jdlrobson mentioned this in T190549: Differentiate between internal, sister-wiki, interwiki, and external links visually.Jul 27 2018, 2:02 AM

ovasileva triaged this task as Medium priority.Jul 30 2018, 8:42 AM

ovasileva added a subscriber: • alexhollender_WMF.

@Jdlrobson yes, it should have an icon. I just checked with Nirzar and it's not and intentional choice from design to hide them.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).Jul 31 2018, 2:36 AM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jul 31 2018, 2:37 PM

Pulling into the spring as this might be a good task for @nray to pick up

• nray claimed this task.Jul 31 2018, 8:55 PM

• nray moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 449613 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Add external link icon to external links in ReferenceDrawer

https://gerrit.wikimedia.org/r/449613

gerritbot added a project: Patch-For-Review.Jul 31 2018, 9:33 PM

• nray moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 31 2018, 9:34 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Aug 1 2018, 12:50 AM

Jdlrobson moved this task from Upcoming to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.Aug 1 2018, 12:53 AM

Change 449613 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add external link icon to external links in ReferenceDrawer

https://gerrit.wikimedia.org/r/449613

• nray reassigned this task from • nray to • alexhollender_WMF.Aug 1 2018, 1:11 AM

Have added QA steps, over to you @alexhollender

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 1 2018, 2:01 AM

looks great

IMG_FE34D9F6197B-1.jpeg (1×750 px, 474 KB)

• alexhollender_WMF reassigned this task from • alexhollender_WMF to Ryasmeen.Aug 1 2018, 2:41 AM

• alexhollender_WMF added a project: Product-QA.

• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

Verified on these articles: http://reading-web-staging.wmflabs.org/wiki/Copenhagen and http://reading-web-staging.wmflabs.org/wiki/Albert_Einstein. Good to go.

Screen Shot 2018-08-03 at 9.31.54 PM.png (150×554 px, 38 KB)

Screen Shot 2018-08-03 at 9.32.09 PM.png (148×514 px, 25 KB)

Ryasmeen moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Aug 3 2018, 7:34 PM

Looks like we're done here. Thanks all!

• Phabricator_maintenance edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Sep 13 2018, 6:39 PM

	F24487564: Screen Shot 2018-08-03 at 9.32.09 PM.png
	Aug 3 2018, 7:34 PM

	F24487561: Screen Shot 2018-08-03 at 9.31.54 PM.png
	Aug 3 2018, 7:34 PM

	F24189381: Screen Shot 2018-07-27 at 10.02.31 AM.png
	Jul 27 2018, 2:02 AM

	F24189359: Screen Shot 2018-07-27 at 10.00.51 AM.png
	Jul 27 2018, 2:02 AM

External links inside ReferenceDrawer do not show the external link iconClosed, ResolvedPublic1 Estimated Story PointsActions