Page MenuHomePhabricator

External links inside ReferenceDrawer do not show the external link icon
Closed, ResolvedPublic1 Estimated Story Points

Description

Visit http://reading-web-staging.wmflabs.org/wiki/Copenhagen
Click a reference link [6]
See reference drawer

Screen Shot 2018-07-27 at 10.00.51 AM.png (182×568 px, 50 KB)

The link inside the reference drawer does not have an external link icon. Should it?

With icon:

Screen Shot 2018-07-27 at 10.02.31 AM.png (156×545 px, 30 KB)

Developer notes

It looks like this is intentional due to the rule

background-image: none;

Trivial to restore icons - remove this line.

QA steps

Can be tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein or http://reading-web-staging.wmflabs.org/wiki/Albert_Einstein

Event Timeline

ovasileva triaged this task as Medium priority.Jul 30 2018, 8:42 AM
ovasileva added a subscriber: alexhollender.

@Jdlrobson yes, it should have an icon. I just checked with Nirzar and it's not and intentional choice from design to hide them.

ovasileva set the point value for this task to 1.Jul 31 2018, 4:10 PM
ovasileva added subscribers: nray, ovasileva.

Pulling into the spring as this might be a good task for @nray to pick up

Change 449613 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Add external link icon to external links in ReferenceDrawer

https://gerrit.wikimedia.org/r/449613

Change 449613 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add external link icon to external links in ReferenceDrawer

https://gerrit.wikimedia.org/r/449613

Looks like we're done here. Thanks all!