Page MenuHomePhabricator

WikibaseLexeme cannot be loaded when CirrusSearch is not enabled
Open, Needs TriagePublic

Description

After https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/437820/ when "entity type definitions" are loaded on the setup without CirrusSearch extension, loading "fulltext-search-context" fails as it references a constant from LexemeFullTextQueryBuilder which in turn implements CirrusSearch\Query\FullTextQueryBuilder interface, which is not there without CirrusSearch.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/448524/ has been a quick fix by repeating the string literal instead referencing the constant.

@Addshore suggested https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/448531/ which is probably going to allow conditional referencing the constant.

Also note that with what T190022 suggests, this part of entity type definitions would probably be moved out of WikibaseLexeme extension