Currently "active nodes" includes
- Block image captions
- Table captions
- CX sections
- ProofreadPage sections
We disable expanding a selection across an active node boundary, but one should still be able to move in and out of them.
Currently "active nodes" includes
We disable expanding a selection across an active node boundary, but one should still be able to move in and out of them.
Change 448571 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Allow cursoring between active nodes
Change 448571 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Allow cursoring between active nodes
For the table caption case, should we special case it so that it jumps the selection into the table rather than skipping it?
Change 449530 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (086de2707)
Change 449530 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (086de2707)
@Deskana: "active node" means one which can have cursor focus within it, in a way that's somewhat separate from the general article flow. This patch makes it so that moving your cursor with the arrow keys doesn't keep it trapped within those nodes. E.g. if you're in a table caption and press the up arrow, you would previously have stayed in the caption, but now you'll find the cursor in the preceding content.
@DLynch/ @Esanders: Are the following cursoring behaviors intentional?
Question 1 is what I was asking above in my first comment on this task, so I'd say that's somewhat-undecided. I think 2 is unintended, though; it should switch to cell selection first.
Change 451331 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Restore cursor trapping functionality to table cells
Change 451331 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Restore cursor trapping functionality to table cells
Change 451530 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e57bf17b)
Change 451530 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e57bf17b)
Change 448580 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] WIP Cursor into table captions if present, instead of the first cell
So it seems the second issue of up arrow skipping the cells in between and moving to the caption field or to the preceding content is almost fixed. I see a flickering cursor in those positions still but that's negligible I suppose or not :) I am marking this issue verified from my side anyways.