Page MenuHomePhabricator

Banner Test Desktop 03: Remove form headline
Closed, ResolvedPublic3 Estimated Story Points

Description

This test is based on the (ctrl|var) banner of T199547. For this test, the form headline of the variant banner ("Ja, ich spende...) is being removed.

Acceptance Criteria

  • The control banner is based on the (ctrl|var) banner of the last test.
  • Campaign parameter is defined as 03-ba-180810.
  • Banner names are defined as B18WMDE_03_180810_ctrl and B18WMDE_03_180810_var respectively.
  • Banner keywords are defined as org-03-180810-ctrl and org-03-180810-var respectively.
  • The form headline of the variant banner is removed.
  • The button labels in the form are vertically centered.

Notes

  • The variant banner of T199547 contains a workaround for resembling the control banner's height. If the control banner of this test is based on the previous variant, the workaround should be removed.
  • The URL in the form action attribute contains two obsolete parameters. These can be removed.
  • We need to put some thought into smaller viewports. The form headline shares space with the bank account data and just removing the "Ja, ich spende" might not be what we want.
  • In the previous tests (also last year), the vertical alignment of the button labels was too high.

Event Timeline

After talking with UX we keep the bank account data position on the "vertical form" as it is.

Tim_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-08-06 board.
Tim_WMDE subscribed.

hey @Tim_WMDE thanks.

three remarks.

  1. please change the start from friday to thursday since we are positive that we have enough data by tomorrow.
  2. please make sure that the form will not move to the top when removing "Ja, ich will spenden". The forms position should be identical to CTRL. Please check the screenshot what we mean. A is CTRL; B is VAR

from headline.PNG (257×356 px, 12 KB)

  1. the same logic applies to the bank account data on the horizontal form. The position of this should be identical and not be left aligned when "Ja, ich will spenden" is removed.

Hey @tmletzko, I have implemented the changes and also updated the campaign so that it will start tomorrow and run for two weeks:

https://phabricator.wikimedia.org/T200597

Let me know if it is good to go now.