Page MenuHomePhabricator
Create Task
Maniphest T200650

Deprecate/obsolete $wgWikimediaJenkinsCI
Closed, ResolvedPublic
Actions

Description

https://codesearch.wmflabs.org/search/?q=wgWikimediaJenkinsCI&i=nope&files=&repos=

This is specific to the Wikimedia CI setup, and really shouldn't be necessary in MediaWiki code. We should come up with other solutions that

  • Don't require $wgExtensionFunctions/"callback"
  • Aren't Wikimedia CI specific

This system needs to identify PHPUnit tests, parser tests, qunit tests, and browser test runs.

Details

SubjectRepoBranchLines +/-
Use onParserTestGlobals instead of wgWikimediaJenkinsCImediawiki/extensions/TimedMediaHandlermaster+6 -11
Enable string functions if running parser/PHPUnit testsmediawiki/extensions/ParserFunctionsmaster+7 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm triaged this task as Medium priority.Jul 29 2018, 7:44 PM
Legoktm created this task.
gerritbot added a comment.Jul 29 2018, 7:48 PM

Change 449034 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ParserFunctions@master] Enable string functions if running parser/PHPUnit tests

https://gerrit.wikimedia.org/r/449034

gerritbot added a project: Patch-For-Review.Jul 29 2018, 7:48 PM
Legoktm edited projects, added Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018); removed Core-Platform-Team-Old.Jul 31 2018, 1:19 AM
Paladox subscribed.Jul 31 2018, 1:20 AM
Legoktm updated the task description. (Show Details)Jul 31 2018, 4:31 AM
CCicalese_WMF moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Aug 7 2018, 12:19 AM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Aug 9 2018, 8:40 PM
CCicalese_WMF assigned this task to Legoktm.Oct 1 2018, 1:32 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).
CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.
CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:16 PM
CCicalese_WMF moved this task from Inbox to Needs Cleaning - Code Health (TEC13) on the Platform Engineering board.Oct 3 2018, 2:17 PM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.
CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 3:57 PM
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.Jan 1 2019, 5:30 PM
Krinkle mentioned this in T198201: Quibble must include tests/selenium/LocalSettings.php (was ORES webdriver.io selenium test fail on CI due to lack of ORES server).Feb 7 2019, 1:55 AM
gerritbot added a comment.Feb 7 2019, 11:41 PM

Change 449034 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Enable string functions if running parser/PHPUnit tests

https://gerrit.wikimedia.org/r/449034

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 8 2019, 12:01 AM
hashar added a project: Technical-Debt (Deprecation process).Apr 3 2019, 8:19 AM
gerritbot added a comment.Apr 3 2019, 3:52 PM

Change 500984 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/TimedMediaHandler@master] Use onParserTestGlobals instead of wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/500984

Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Apr 3 2019, 4:40 PM
gerritbot added a comment.Apr 4 2019, 4:20 AM

Change 500984 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use onParserTestGlobals instead of wgWikimediaJenkinsCI

https://gerrit.wikimedia.org/r/500984

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Apr 4 2019, 5:01 AM
Legoktm removed Legoktm as the assignee of this task.May 19 2019, 8:09 AM

Not currently working on this.

Maintenance_bot removed a project: Patch-For-Review.May 23 2019, 10:48 AM
WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (Doing).Jul 5 2019, 6:30 PM
Legoktm mentioned this in T229996: How to set global variables for CI environment?.Aug 9 2019, 10:42 PM
WDoranWMF removed a project: Platform Engineering (Needs Cleaning - Code Health (TEC13)).Aug 13 2019, 7:01 PM
Krinkle closed this task as Resolved.Sep 30 2019, 1:30 AM
Krinkle assigned this task to Legoktm.
Krinkle edited projects, added MediaWiki-extensions-General; removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Continuous-Integration-Infrastructure, WMF-General-or-Unknown.

Looking at the search results now I see only:

  • Wikibase - specific to CI (various settings)
  • CentralAuth - specific to CI (turn local wiki into central wiki)
  • ConfirmEdit - specific to CI (something about optimising with T44145, not sure if still relevant but seems innocent)
  • GlobalBlocking - specific to CI (turn local wiki into central wiki)

That's all folks :) Seems good enough to close?

hashar subscribed.Oct 25 2019, 11:50 AM

Yes +1 :]

Reedy mentioned this in T273302: Document how to do CI specific config.Jan 29 2021, 5:02 PM
Reedy subscribed.Jan 29 2021, 5:57 PM

For cross referencing purposes... T267928: Configuration Modes

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL