Page MenuHomePhabricator

Change the help Icon position as shown in the below Image.
Open, Needs TriagePublic

Description

In Mediawiki-RevisionSlider change the help Icon position from existing position to the side of pin Icon.

Proposal.png (355×1 px, 49 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@WMDE-Fisch what do you say? are you ok with this task?

@WMDE-Fisch what do you say? are you ok with this task?

Task looks good, thank you :-). Now it's to be discussed by the ones responsible if this is something we want to have. - But having a proper task is the first step.

Related to this, the overhaul of the 'help' icon was seen as the biggest “disruption” in T177432 and as such a rather small one altogether. Still there have been requests for a more clear help icon and we've provided 'helpNotice' in v0.28.2 of OOUI.
I had RevisionSlider together with RCFilters T204165 (you can also see it in action there) in mind when adding it to the library.
Please consider it and give me feedback, I'd propose a patch.

@Volker_E If the help icons are being overhauled then I think we should have the updated version in the rev slider as well. A patch would be much appreciated.

@Gopavasanth I had a look at your proposal and i think that it could cause potential problems if we add the help icon into the bar. we'd have to think of how it should behave when the rev slider is opened since the pin isn't visible when closed. We would be causing a jumping behavior because the icon would slide in between the help and the arrow.

I agree that the current help position is not great so my proposal is this (already using the new icon that volker proposed):

helpPlacementLarge.png (271×1 px, 13 KB)

helpPlacementsmall.png (270×1 px, 7 KB)

Here is another mock with the specification of the icon alignment. Please reference this mock for the placement of the icon. It should also be 20x20 like the other ones.

helpPlacementSpec.png (271×1 px, 13 KB)

As you can see the icon should be sticking to the frame of the drop down and not stick to the back and forth arrow as it currently is.

If you have any further questions, let me know! And thank you for proactively opening this ticket.

@Charlie_WMDE Top right position makes perfect sense.

Like , the problem is that when trying to move the icon from its location , along with it even the slider bar button is moving ,can i have some idea on how to separate the icons and make them individual.

I'm afraid I don't know how to help.

I know the code that positions the two current "pin" and "expand/collapse" buttons is a bit iffy (absolute position in CSS, which I really don't like for a multitude of reasons). I can imagine it's hard to position another one next to the two, without breaking the other two. The cheapest solution is probably to repeat the CSS that exists for .mw-revslider-auto-expand-button, and change the right position accordingly.

If that was the question. Maybe I misunderstood.

Change 472772 had a related patch set uploaded (by Lohitha; owner: Lohitha):
[mediawiki/extensions/RevisionSlider@master] Changed help icon position

https://gerrit.wikimedia.org/r/472772

@Charlie_WMDE I'd suggest to put the down icon (currently 4px) and the pin icon with a default right distance of 8px in order to not make the help icon be too close to the right edge either in the after patch setting.

Change 473253 had a related patch set uploaded (by Harshith; owner: Harshithpabbati):
[mediawiki/core@master] Changed the position of the question mark BUG ID-T200697

https://gerrit.wikimedia.org/r/473253

Change 473253 abandoned by VolkerE:
Changed the position of the question mark BUG ID-T200697

Reason:
Should have mentioned, this is the wrong place for addressing the issue, it should be tackled in RevisionSlider extension itself like in I4e9e5d0ff35c21d

https://gerrit.wikimedia.org/r/473253

@Harshith1304: This issue has been assigned to you a while ago.
Are you still working (or still plan to work) on this issue? Is there anything that others could help with? If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action...Assign / Claim in the dropdown menu) so others could work on it. Thanks a lot!

thiemowmde added a subscriber: Harshith1304.

Change 472772 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/RevisionSlider@master] Changed help icon position

Reason:
I'm afraid this patch needs to be redone, probably not leaving anything it does right now. After 2 years of inactivity I suggest to start over.

https://gerrit.wikimedia.org/r/472772