Page MenuHomePhabricator

Misleading block messages when an IP is affected by two range blocks
Open, Needs TriagePublic

Description

A good user was affected by a global IP range block and the block message referred this to 89.144.221.0/24. He went to https://meta.wikimedia.org/wiki/Special:Contributions/89.144.221.0/24 where you can find the following block messages:

This IP address is currently blocked. The latest block log entry is provided below for reference:

  • 14:09, 21 May 2018 Green Giant (talk | contribs | block) blocked 89.144.220.0/22 (talk) with an expiration time of 1 year (anonymous users only, account creation disabled, cannot edit own talk page) (Long-term abuse: per request (if you are affected by this block, please [stewards@wikimedia.org contact us]) (unblock | change block)

This IP address is currently globally blocked. The global block log entry is provided below for reference:

  • 14:09, 21 May 2018: Green Giant (meta.wikimedia.org) globally blocked 89.144.220.0/22 (expires on 21 May 2019 at 14:09, anonymous only) (edits · IP check · whois) (Long-term abuse: per request (if you are affected by this block, please [stewards@wikimedia.org contact us]) (remove | modify)

However, both these blocks are anonymous only. The global block without anon-only that really affected him was https://meta.wikimedia.org/wiki/Special:Log?type=gblblock&page=User:89.144.221.0/24

18:41, 7 May 2018 Ruslik0 (talk | contribs | block) globally blocked User:89.144.221.0/24 (expiration 18:41, 7 May 2019) (Long-term abuse)

For stewards who want to set a new range block, there is no way to identify whether a smaller or bigger range is already blocked and what settings it has, or not.

Two things could be improved (if useful, split this into two bug reports):

  • (short term) show all log entries that affect a range on Special:Contributions
  • (long term) let the global blocking system check if there is already a smaller or bigger range blocked

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2018, 10:41 PM
Man77 awarded a token.Jul 31 2018, 2:44 PM
PiRSquared17 added a comment.EditedApr 14 2019, 6:32 PM

I think the (short term) issue could be fixed simply by removing the two "->setLimit( 1 )"s in:

https://github.com/wikimedia/mediawiki-extensions-GlobalBlocking/blob/e27d9fd0e14f16c0dd75a4a00445e9e0b64094cd/includes/GlobalBlockingHooks.php

(Note: I haven't tested this.)

You can also view the full list of applicable global blocks on Special:GlobalBlockList (e.g. https://meta.wikimedia.org/wiki/Special:GlobalBlockList/137.59.87.179 ). Maybe we should just modify the block message to link there?

By the way, does the same problem with only showing one block apply to local blocks?