Maniphest T200771

SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "ContentTranslationStats"
Closed, ResolvedPublic
Actions

Description

It seems b50c884 has caused or exposed a fatal error in MediaWiki core that affects ContentTranslation as can be seen in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/7190/console:

1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "ContentTranslationStats" (SpecialContentTranslationStats Object (...))
Error: Call to a member function getPrefixedDBkey() on null

/workspace/src/includes/skins/SkinTemplate.php:181
/workspace/src/includes/skins/SkinTemplate.php:539
/workspace/src/extensions/ContentTranslation/specials/ContentTranslationSpecialPage.php:81
/workspace/src/extensions/ContentTranslation/specials/ContentTranslationSpecialPage.php:53
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:105
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
/workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:41
/workspace/src/tests/phpunit/MediaWikiTestCase.php:469
/workspace/src/maintenance/doMaintenance.php:94

It feels as if the title for the request context is not set properly.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialPageExecutor, make sure Skin context is correctly set	mediawiki/core	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T200693: Test failure in WikibaseLexeme selenium tests block merging patches to ContentTranslation
Mentioned Here: rMWb50c8848e6e8: Introduce SpecialPageFatalTest

Event Timeline

Nikerabbit created this task.Jul 31 2018, 9:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2018, 9:33 AM

Addshore added a project: User-Addshore.Jul 31 2018, 9:49 AM

Change 449436 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] SpecialPageExecutor, make sure Skin context is correctly set

https://gerrit.wikimedia.org/r/449436

gerritbot added a project: Patch-For-Review.Jul 31 2018, 10:12 AM

As ContentTranslation is a wmf deployed extension, perhaps it should be loaded while the core CI runs?

@hashar, thoughts?

Addshore moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 31 2018, 10:14 AM

Addshore added a subscriber: hashar.

Tarrow mentioned this in T200693: Test failure in WikibaseLexeme selenium tests block merging patches to ContentTranslation.Jul 31 2018, 10:49 AM

Change 449418 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] DNM Testing T200771

https://gerrit.wikimedia.org/r/449418