Maniphest T200823

Site stats not updating when links added to pages
Closed, ResolvedPublic
Actions

Description

We've had two reports of this now, T199041 and T200726.

Naturally adding links doesn't increase the article count, but running initSiteStats.php does.

Some fallout of the MCR changes?

Details

	Subject	Repo	Branch	Lines +/-
	Fix article counting logic in DerivedPageDataUpdater	mediawiki/core	wmf/1.32.0-wmf.15	+16 -2
	Fix article counting logic in DerivedPageDataUpdater	mediawiki/core	master	+16 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T200847 {{NUMBEROFARTICLES}} is not updating as expected at he.wikivoyage.org
Resolved	Reedy	T199041 Pswikivoyage content pages counting issues
Resolved	Benoit_Rochon	T200726 atj:Special:Statistics: number of pages seems to be stucked at 501
Resolved	Catrope	T200119 No page link notifications since around end of June
Resolved	Reedy	T200869 NUMBEROFARTICLES seems off in fawiki
Resolved	Tgr	T200823 Site stats not updating when links added to pages

Event Timeline

Reedy created this task.Jul 31 2018, 5:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2018, 5:05 PM

Reedy triaged this task as High priority.Jul 31 2018, 5:05 PM

Reedy added a project: Regression.

DerivedDataPageUpdater saves the old state in pageState but then never uses it. Probably $pageState['oldCountable'] should override $options['oldcountable'] in doUpdates() when the latter is null.

Tgr added a project: Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).Jul 31 2018, 6:58 PM

Cirdan mentioned this in T200119: No page link notifications since around end of June.Jul 31 2018, 7:00 PM

Cirdan subscribed.Jul 31 2018, 7:07 PM

Reedy added parent tasks: T200847: {{NUMBEROFARTICLES}} is not updating as expected at he.wikivoyage.org, T199041: Pswikivoyage content pages counting issues, T200726: atj:Special:Statistics: number of pages seems to be stucked at 501, T200119: No page link notifications since around end of June.Jul 31 2018, 9:13 PM

Benoit_Rochon subscribed.Jul 31 2018, 11:06 PM

matmarex added a parent task: T200869: NUMBEROFARTICLES seems off in fawiki.Aug 1 2018, 3:05 AM

@Tgr is probably right. I can look into this later today if nobody else does.

Change 449704 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Fix article counting logic in DerivedPageDataUpdater

https://gerrit.wikimedia.org/r/449704

gerritbot added a project: Patch-For-Review.Aug 1 2018, 12:28 PM

Dcljr subscribed.Aug 1 2018, 4:34 PM

Tgr moved this task from Backlog to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Aug 2 2018, 12:57 PM

Change 449704 merged by jenkins-bot:
[mediawiki/core@master] Fix article counting logic in DerivedPageDataUpdater

https://gerrit.wikimedia.org/r/449704

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 3 2018, 12:00 PM

Fix is merged. Does this need a backport? Or can this wait to go out with the train next week?

Also, do we need to run initSiteStats.php on all wikis? (Is that even feasible on large ones?)

In T200823#4476605, @Tgr wrote:

Also, do we need to run initSiteStats.php on all wikis? (Is that even feasible on large ones?)

I think we just wait for https://github.com/wikimedia/puppet/blob/860482004dc69dc61d5d26e4985d70dbe2954228/modules/mediawiki/manifests/maintenance/initsitestats.pp to fix the problems

Change 450225 had a related patch set uploaded (by Reedy; owner: Gergő Tisza):
[mediawiki/core@wmf/1.32.0-wmf.15] Fix article counting logic in DerivedPageDataUpdater

https://gerrit.wikimedia.org/r/450225

Change 450225 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.15] Fix article counting logic in DerivedPageDataUpdater

https://gerrit.wikimedia.org/r/450225

Reedy closed this task as Resolved.Aug 3 2018, 2:11 PM

Reedy assigned this task to Tgr.

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 3 2018, 3:01 PM

CCicalese_WMF moved this task from Inbox to Closed on the Core-Platform-Team-Old board.Aug 6 2018, 10:40 PM

CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Aug 8 2018, 5:13 PM