[{exception_id}] {exception_url} ErrorException from line 269 of /srv/mediawiki/php-1.32.0-wmf.14/extensions/PagedTiffHandler/PagedTiffHandler_body.php: PHP Notice: Undefined index: 41

Example URL: https://commons.wikimedia.org/w/index.php?title=File:Ackermann_-_%C5%92uvres_de_L._Ackermann.tif&page=40

Trace log

message:
PHP Notice: Undefined index: 41

wiki: commons.wikimedia.org

exception.trace:
#0 /srv/mediawiki/php-1.32.0-wmf.14/extensions/PagedTiffHandler/PagedTiffHandler_body.php(269): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.14/includes/filerepo/file/File.php(1079): PagedTiffHandler->normaliseParams(LocalFile, array)
#2 /srv/mediawiki/php-1.32.0-wmf.14/includes/Linker.php(565): File->transform(array)
#3 /srv/mediawiki/php-1.32.0-wmf.14/includes/Linker.php(500): Linker::makeThumbLink2(Title, LocalFile, array, array)
#4 /srv/mediawiki/php-1.32.0-wmf.14/includes/page/ImagePage.php(474): Linker::makeThumbLinkObj(Title, LocalFile, string, string, string, array)
#5 /srv/mediawiki/php-1.32.0-wmf.14/includes/page/ImagePage.php(138): ImagePage->openShowImage()
#6 /srv/mediawiki/php-1.32.0-wmf.14/includes/actions/ViewAction.php(68): ImagePage->view()
#7 /srv/mediawiki/php-1.32.0-wmf.14/includes/MediaWiki.php(500): ViewAction->show()
#8 /srv/mediawiki/php-1.32.0-wmf.14/includes/MediaWiki.php(294): MediaWiki->performAction(ImagePage, Title)
#9 /srv/mediawiki/php-1.32.0-wmf.14/includes/MediaWiki.php(867): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.32.0-wmf.14/includes/MediaWiki.php(524): MediaWiki->main()
#11 /srv/mediawiki/php-1.32.0-wmf.14/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Source at PagedTiffHandler_body:251.

	function normaliseParams( $image, &$params ) {
		if ( isset( $params['page'] ) ) {
			$params['page'] = $this->adjustPage( $image, $params['page'] );
		} else {
			$params['page'] = $this->firstPage( $image );
		}
		if ( isset( $params['lossy'] ) ) {
			// ..
		} else {
			$page = $params['page'];
			$data = $this->getMetaArray( $image );
			if ( !$this->isMetadataError( $data )
				&& strtolower( $data['page_data'][$page]['alpha'] ) == 'true'

Related Objects

Mentioned In: T273645: PagedTiffHandler.php PHP Notice: Undefined offset: 332

Event Timeline

Krinkle created this task.Jul 31 2018, 7:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2018, 7:17 PM

LGoto moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 8 2018, 3:51 PM

We need to find out how often this error is happening and if it has any serious impact to prioritize.

@Jhernandez Thanks. I wasn't entirely sure whether you're asking me or documenting for future handling within the team. Anyhow, the errors can be analysed at https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-errors (query "PagedTiffHandler" in last 7 days).

The tiff contains 199 pages, but starts by 2 and ends on 213 with some gaps, but the preview of mediawiki assumed the page numbers are straight forward. This also makes it impossible to visit pages 200 to 213

Missing 1, 32, 41, 63, 76, 103, 107, 116, 120, 154, 167, 197, 201, 210

https://commons.wikimedia.org/w/api.php?action=query&titles=File:Ackermann_-_%C5%92uvres_de_L._Ackermann.tif&prop=imageinfo&iiprop=metadata

{
    "name": "page_count",
    "value": 199
},
{
    "name": "first_page",
    "value": 2
},
{
    "name": "last_page",
    "value": 213
},

But first and last are reset in PagedTiffImage::finish, maybe the array index of page_data must reset too

Ye @Krinkle just documenting next steps for me or the team to look into. Thanks for the report. Thanks @Umherirrender for the example.

I've looked at the logs and I've seen 10 instances of the error mostly in commons in the last 30 days:

Screen Shot 2018-08-17 at 17.33.06.png (1,116×372 px, 126 KB)

We have to look into it but doesn't seem extremely urgent. If anyone wants to dig in, feel free.

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 29 2018, 8:24 PM

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 13 2018, 12:35 AM

@Jhernandez Understandable. Note that if the resulting behaviour is considered acceptable for the time being (which it sounds like) , it might scale better to silence it the application error (catch, suppress , or lower severity), so that it doesn't register in our shared infrastructure as a problem. Especially because it makes it harder to find new problems each week, and because it might falsely cause deployment to fail or alerts to fire.

The tiff has 212 pages, mediawiki metadata sees only 199. The page number 1 is missing, therefor the first and second page on the image page is same, because the page with the lowest number (2) is the first page, but when requesting a page per parameter, the page with that number is returned. That results in two pages which are the same

But it seems mediawiki can see the page with number 1
https://upload.wikimedia.org/wikipedia/commons/thumb/5/51/Ackermann_-_%C5%92uvres_de_L._Ackermann.tif/lossy-page1-541px-Ackermann_-_%C5%92uvres_de_L._Ackermann.tif.jpg
which looks different than the first page on the file page, that is page 2
https://upload.wikimedia.org/wikipedia/commons/thumb/5/51/Ackermann_-_%C5%92uvres_de_L._Ackermann.tif/lossy-page2-541px-Ackermann_-_%C5%92uvres_de_L._Ackermann.tif.jpg

Maybe it is enough to refresh the metadata for this image.

The other solution is to fix PagedTiffHandler to store the metadata without gaps, because the multi page navigation assume that the pages are stored without gaps to navigate through all of them.

Umherirrender added a project: Multimedia.Sep 19 2018, 7:16 PM

Umherirrender merged a task: T221409: PHP Notice: Undefined index: 88 in PagedTiffHandler_body.php.Apr 19 2019, 9:03 AM

Umherirrender added a subscriber: • mmodell.

(Still seen on 1.34-wmf.7)

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM

• Jhernandez unsubscribed.Apr 2 2020, 6:46 PM

Seeing a few of these in wmf.37 for: http://commons.wikimedia.org/wiki/File:Gautier_-_Tableaux_de_Si%C3%A8ge.tif?page=21

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jun 24 2020, 6:39 PM

• sdkim moved this task from Backlog to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.Oct 16 2020, 2:29 PM

• sdkim moved this task from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Dec 1 2020, 6:23 PM

• sdkim edited projects, added: Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed: Product-Infrastructure-Team-Backlog-Deprecated.

Samwilson mentioned this in T273645: PagedTiffHandler.php PHP Notice: Undefined offset: 332.Feb 4 2021, 10:47 AM

• dancy merged a task: T273645: PagedTiffHandler.php PHP Notice: Undefined offset: 332.Feb 4 2021, 3:58 PM

• dancy added a subscriber: Samwilson.

• dancy subscribed.

I wasn't aware of this ticket when I fixed this bug: https://gerrit.wikimedia.org/r/659307. It's already merged. I believe this ticket can be closed, and the exception(s) removed from the mediawiki-new-errors board: https://logstash.wikimedia.org/app/dashboards#/view/0a9ecdc0-b6dc-11e8-9d8f-dbc23b470465?_g=h@8130aac&_a=h@f4fbfdc.

ssastry removed a project: Product-Infrastructure-Team-Backlog-Deprecated (Kanban).Feb 9 2021, 3:54 PM

Hi @thiemowmde. Can you confirm that the use of ?? in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PagedTiffHandler/+/659307/1/includes/PagedTiffHandler.php covers the case where $data['page_data'][$page] is null?

Yes, absolutely, it does.

Awesome. Thanks!

Does that mean that the status of this ticket should be changed to resolved?

In T200839#6814546, @thiemowmde wrote:

I believe this ticket can be closed, and the exception(s) removed from the mediawiki-new-errors board: https://logstash.wikimedia.org/app/dashboards#/view/0a9ecdc0-b6dc-11e8-9d8f-dbc23b470465?_g=h@8130aac&_a=h@f4fbfdc.

Done. Thanks!

In T200839#6819660, @Aklapper wrote:

Does that mean that the status of this ticket should be changed to resolved?

Yes.

Jdforrester-WMF closed this task as Resolved.Feb 10 2021, 6:47 PM

PHP Notice: Undefined index from PagedTiffHandler_body.php:269Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Related Objects

Event Timeline

PHP Notice: Undefined index from PagedTiffHandler_body.php:269
Closed, ResolvedPublicPRODUCTION ERROR
Actions