Page MenuHomePhabricator

Pingback on non-MySQL databases fails to save to updatelog, generates a high rate of unique pings
Closed, ResolvedPublic

Description

After fbba5dae54e0396d859a7e32872d60e9909213a9, pingback was supposed to send a monthly heartbeat ping. Due to an implementation error, on DBMSs other than MySQL, the timestamp is not updated, so the rate of pings is only limited by the lock feature, producing one ping per hour assuming ObjectCache is configured appropriately.

A new installation ID is generated each time, because the insertion of the ID is rolled back when the query error occurs.

The effect on our statistics is shown in the graph below.

We should probably do a minor release, and also filter out all pings which have an MW version and DBMS known to be affected.

Event Timeline

Change 449641 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Fix pingback on non-MySQL

https://gerrit.wikimedia.org/r/449641

Change 449641 merged by jenkins-bot:
[mediawiki/core@master] Fix pingback on non-MySQL

https://gerrit.wikimedia.org/r/449641

Change 450050 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[analytics/reportupdater-queries@master] Filter out erroneous pingback data caused by T200864.

https://gerrit.wikimedia.org/r/450050

Change 450050 merged by Cicalese:
[analytics/reportupdater-queries@master] Filter out erroneous pingback data caused by T200864.

https://gerrit.wikimedia.org/r/450050

Change 450983 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[analytics/reportupdater-queries@master] Filter out more erroneous pingback data caused by T200864.

https://gerrit.wikimedia.org/r/450983

Change 450983 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[analytics/reportupdater-queries@master] Filter out more erroneous pingback data caused by T200864.

https://gerrit.wikimedia.org/r/450983

Change 450983 merged by Cicalese:
[analytics/reportupdater-queries@master] Filter out more erroneous pingback data caused by T200864.

https://gerrit.wikimedia.org/r/450983

Change 456057 had a related patch set uploaded (by Legoktm; owner: Tim Starling):
[mediawiki/core@REL1_31] Fix pingback on non-MySQL

https://gerrit.wikimedia.org/r/456057

Change 456057 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fix pingback on non-MySQL

https://gerrit.wikimedia.org/r/456057