Page MenuHomePhabricator

Log database errors in Membership application
Closed, DeclinedPublic2 Estimated Story Points

Description

In many cases we are returning "error" responses in membership use cases, masking the database errors. We'd rather be aware of the low-level errors to be able to fix it.

AC: All database-related exceptions are caught and logged.

Note: There are some TODO comments in the code, which have been there for a long time instead of being a proper ticket and might be removed when we get to this ticket. See commit ID 4cd301ca92f1dd5fa7bcba59249a42adee9014f1 and look for "TODO" comments in the code.

Event Timeline

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptAug 1 2018, 12:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen set the point value for this task to 2.Sep 24 2018, 10:56 AM
gabriel-wmde closed this task as Declined.Oct 28 2020, 9:39 AM

Instead of passing around a logger to the use case, we rely on the centralized exception handler & logger.
Recoverable service calls should be wrapped in classes that do the recovery and logging