Page MenuHomePhabricator

Have wm-bot use SASL or solve global bans problem
Open, LowPublic

Description

Currently, wm-bot attempts to join before Freenode services are able to properly authenticate the bot. This is causing issues with the current broad-strokes solution to spam, which is to ban all unauthenticated accounts from joining.

The solution is one of a couple things:

  • Stop maintaining a long $~a ban in #wikimedia-bans
  • Remove channels affected by this global ban from the global ban list (already implemented in wm-bot's channel)
  • Have wm-bot use SASL

The third option is obviously preferred, however; it is the one that will take the longest. This ticket is mainly to track that progress.

Event Timeline

Restricted Application added a project: User-Matthewrbowker. · View Herald TranscriptAug 1 2018, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Az1568 moved this task from Backlog to Bans on the wikimedia-irc-freenode board.Aug 10 2018, 6:13 AM
Matthewrbowker removed Matthewrbowker as the assignee of this task.Sep 25 2018, 4:15 PM

Another option: Simply have wm-bot wait until it's identified before it joins channels.

Matthewrbowker raised the priority of this task from Medium to Needs Triage.Sep 25 2018, 4:32 PM
Matthewrbowker moved this task from Inbox to Created on the User-Matthewrbowker board.
valhallasw added a subscriber: valhallasw.EditedNov 14 2018, 6:00 PM

Or: use a server password (see https://freenode.net/kb/answer/registration#logging-in).

which can probably be done by adding

this.Send("PASS" + Configuration.IRC.LoginNick + ":" + Configuration.IRC.LoginPw)

before the USER command at https://github.com/benapetr/wikimedia-bot/blob/master/src/WMBot/IRC/WmIRCProtocol.cs#L55

Petrb triaged this task as Low priority.EditedDec 10 2018, 9:33 PM

Or: use a server password (see https://freenode.net/kb/answer/registration#logging-in).
which can probably be done by adding

this.Send("PASS" + Configuration.IRC.LoginNick + ":" + Configuration.IRC.LoginPw)

before the USER command at https://github.com/benapetr/wikimedia-bot/blob/master/src/WMBot/IRC/WmIRCProtocol.cs#L55

that also doesn't work when nickserv is down or heavy lagged and responds after several minutes (that happens quite a lot during DDoS attacks and netsplits, which is typically when wm-bot reconnects).

Keep in mind that thanks to bouncer system wm-bot is more stable than most of freenode, it reconnects mostly when freenode servers are crashing or have network issues. Or, of course, when wikimedia cloud services are crashing or having troubles.