Maniphest T201008

Civi: some CIDs not opening
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To

Authored By

	MBeat33
	Aug 2 2018, 1:52 PM

Description

Civi is behaving oddly in that some CIDs load for viewing normally, but DS agent Bill reported that CID 12919617 is not loading. I'm able to replicate the error. If I go to Find Contacts Advanced Search and paste 12919617 into Contact ID, I do see the summary in the next screen, including the donor's name. When we click on the donor's name link however, we see 'waiting for civicrm.wikimedia.org...'

Bill also reports receiving: "civicrm.wikimedia.org is currently unable to handle this request. HTTP ERROR 500" but I haven't seen that yet.

CIDs 5070569and 92087 are others that behave this way. Can't open change logs for these to look for commonalities.

Details

Subject	Repo	Branch	Lines +/-
Re-apply lost patch : Port activity tab performance fix	wikimedia/fundraising/crm/civicrm	master	+59 -58
Revert "Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount"	wikimedia/fundraising/crm/civicrm	master	+19 -19
Port activity tab performance fix	wikimedia/fundraising/crm/civicrm	master	+59 -58

Customize query in gerrit

Related Objects

Mentioned In: T204731: Civi: some CIDs not opening

Event Timeline

MBeat33 created this task.Aug 2 2018, 1:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2018, 1:52 PM

MBeat33 updated the task description. (Show Details)Aug 2 2018, 1:52 PM

MBeat33 renamed this task from Civi: CID 12919617 not opening to Civi: some CIDs not opening.Aug 2 2018, 2:00 PM

MBeat33 updated the task description. (Show Details)

Yeah I can duplicate, it is running past the (newly doubled) 60s max execution time. My guess is something changed in the code that made this slower because we were getting by with 30s until yesterday.

@Ejegg @Eileenmcnaughton any ideas?

This is not affecting a ton of records, but we do have several donor-initiated recurring donation updates on hold for the moment.

Yeah I was hoping to push out the fix on this until next week but I know how to tackle this in code -there is a proposed patch I can trial & port

Change 450175 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Port activity tab performance fix

https://gerrit.wikimedia.org/r/450175

gerritbot added a project: Patch-For-Review.Aug 3 2018, 12:23 AM

Change 450177 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Revert "Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount"

https://gerrit.wikimedia.org/r/450177

I just pushed up a patch https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/450175/ and also deployed it on staging

The upstream PR is https://github.com/civicrm/civicrm-core/pull/12557

I also pushed up a separate patch which offers a revert alternative - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/450177/ - I think the former one is the correct fix but people might feel more comfortable reverting & reviewing next week

Change 450175 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Port activity tab performance fix

https://gerrit.wikimedia.org/r/450175

Looks like @Eileenmcnaughton's fix was the real deal! Just deployed it, and all of the cids mentioned in this ticket are loading snappily. Heck, even Anonymous Anonymous (cid=72), with more than 18,000 donations, is loading in under 5 sec.

Ejegg assigned this task to Eileenmcnaughton.Aug 3 2018, 2:44 AM

Ejegg triaged this task as High priority.

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Owls board.

Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptAug 3 2018, 2:44 AM

Change 450177 abandoned by Ejegg:
Revert "Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount"

Reason:
Went for the real fix instead, seems to work great!

https://gerrit.wikimedia.org/r/450177

Thanks, @Eileenmcnaughton & @Ejegg, this is excellent.

Ejegg closed this task as Resolved.Aug 7 2018, 8:14 PM

MBeat33 mentioned this in T204731: Civi: some CIDs not opening.Sep 18 2018, 3:40 PM

Change 461263 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Re-apply lost patch : Port activity tab performance fix

https://gerrit.wikimedia.org/r/461263

Change 461263 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Re-apply lost patch : Port activity tab performance fix