| RHo | |
| Aug 2 2018, 4:53 PM |
| F27315604: IMG_E5CB36AB729D-1.jpeg | |
| Nov 26 2018, 7:19 PM |
| F26981601: Screenshot_20181030-172457.png | |
| Oct 30 2018, 3:29 PM |
| F25694098: image.png | |
| Sep 7 2018, 5:53 PM |
| F24445714: image.png | |
| Aug 2 2018, 4:53 PM |
| F24445015: image.png | |
| Aug 2 2018, 4:53 PM |
Wikipedia 2.7.239-alpha-2018-08-02
Change 450258 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Design tweak: fix style of reading list name/description dialog.
Change 450258 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: fix style of reading list name/description dialog.
Hi @Dbrant - font sizes and weight are fixed, but the color of inputted text should be the 'Material theme Primary' color once filled (and 'Material theme Disabled/De-emphasised' when hint text)
Change 458859 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Design tweak: text colors in TextInputDialog.
Change 458859 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: text colors in TextInputDialog.
@Dbrant the colors look great on the description hint text, but I'm now seeing the Reading list title hint text persist instead of disappearing
Would it be possible for the field to be cleared when the user taps into the Reading list title field or starts typing, without having the example text appear in black or having it be highlighted?
@cmadeo I'm not totally sure what you mean: are you referring to the blue hint text that floats above the reading list title? If so, this is a standard part of Android input fields.
@Dbrant, ah, no I meant the text that is in the text field. It is black and highlighted rather than grey and unhighlighted like the text field below.
@cmadeo Oh sorry, I see what you mean.
So actually, the text "My reading list" is not a hint, but a pre-populated name for the new reading list. If you choose to click OK, it will actually use that title for the new list. Otherwise you can start typing another title, which will automatically wipe out the pre-highlighted default text.
Do we want to get rid of this behavior?
@Dmitry Brant <dbrant@wikimedia.org>, ah! Thanks for the clarification!
Hmm, I'm assuming that this is the same behavior if a user already has a
list called 'My reading list'?
Yes, in that case the prepopulated text will still be "My reading list", and the text box will show a warning that this name already exists.
@Dbrant if it's not too much trouble then, my preference would be to get rid of this behavior and just use placeholder text that disappears on cursor highlight instead.
Change 471030 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Don't prepopulate reading list name when creating new list.
Change 471030 merged by jenkins-bot:
[apps/android/wikipedia@master] Don't prepopulate reading list name when creating new list.
@Dbrant this is looking good, but would it be possible to have the placeholder text still appear when the keyboard is opened (similar to iOS below).
@cmadeo Unfortunately that's not the standard behavior of the Android text input component. The placeholder ("label") text automatically gets shifted to the top of the field when it receives focus.