Page MenuHomePhabricator
Create Task
Maniphest T201088

CX2: Alignment broken after adding a template
Closed, ResolvedPublic
Actions

Description

Although broken alignment is topic of T200323: CX2: Section alignment still sluggish and breakable, this ticket is describing more specific case. While testing T199308 with en:Uma_Thurman page, I have once again witnessed broken alignment, which remains broken until new paragraph is added.
Here are two screenshots showing how template overlaps two sections. Placeholders appear on top of template.

cx2-template-not-aligned.png (938×1 px, 106 KB)

cx2-template-not-aligned-overlapping.png (937×1 px, 116 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+24 -0Register TransclusionNode rerender as a section change
Customize query in gerrit

Related Objects

Event Timeline

• Petar.petkovic created this task.Aug 2 2018, 7:58 PM
Pginer-WMF added a project: Language-2018-July-September.Aug 3 2018, 7:24 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-July-September board.Aug 6 2018, 8:54 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.Aug 6 2018, 9:57 AM
santhosh updated the task description. (Show Details)Aug 8 2018, 10:03 AM
• Petar.petkovic mentioned this in T203243: CX2: Coordinates break alignment.Aug 31 2018, 12:32 PM
santhosh claimed this task.Sep 18 2018, 11:45 AM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptSep 18 2018, 11:45 AM
santhosh moved this task from Priority backlog to In Progress on the Language-2018-July-September board.Sep 18 2018, 11:46 AM
gerritbot added a subscriber: gerritbot.Sep 18 2018, 12:27 PM

Change 461115 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Register TransclusionNode rerender as a section change

https://gerrit.wikimedia.org/r/461115

gerritbot added a project: Patch-For-Review.Sep 18 2018, 12:28 PM
santhosh moved this task from In Progress to In Review on the Language-2018-July-September board.Sep 18 2018, 12:28 PM
gerritbot added a comment.Sep 19 2018, 1:18 PM

Change 461115 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Register TransclusionNode rerender as a section change

https://gerrit.wikimedia.org/r/461115

• Petar.petkovic removed a project: Patch-For-Review.Sep 19 2018, 1:20 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 2:00 PM
Etonkovidova closed this task as Resolved.Sep 22 2018, 12:56 AM
Etonkovidova added a subscriber: Etonkovidova.

The issue is not present anymore in cx2 - even when the translated template occupies more space then in the source article, the content will be shifted down accordingly, so no overlap would happen.

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Sep 23 2018, 7:19 PM
• Petar.petkovic removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL