Page MenuHomePhabricator

[testwiki] NPP: 'Mark as patrolled' link is present Draft namespace articles
Closed, ResolvedPublic

Description

  1. On testwiki, create an article in Draft namespace (the user should not be a Patroller).
  2. As a user with Patroller rights, check on Special:NewPagesFeed if the article is in Unreviewed (or All) filtered results. Since NPP is checking only for Article and User namespaces, a newly created article in Draft namespace won't be shown.
  3. As a Patroller go to the article and see that the link: 'Mark as patrolled' is present there.

Screen Shot 2018-08-02 at 1.30.07 PM.png (275×1 px, 72 KB)

Event Timeline

On enwiki the 'Mark this page as patrolled' link appears on all new pages in all namespaces not created by users with autopatrol. This is from MediaWiki-Patrolling (wgUseNPPatrol), not PageTriage and is enabled on almost all Wikimedia wikis.

Marking a draft as patrolled should have no impact on review with AFCH (or PageCuration if moved to mainspace).

Thanks @JJMC89. I wasn't sure what the behavior was on English Wikipedia because I'm not a Patroller. So you're saying that that link currently appears in English Wikipedia for Drafts?

So you're saying that that link currently appears in English Wikipedia for Drafts?

Yes. I just double-checked a couple new drafts to confirm.

Thank you. @Etonkovidova -- if that's the case, then I think we don't need to worry about this, right?

+ PageTriage please.

Edit: Or is this English-Wikipedia-New-Pages-Patrol ? In any case, such tasks need a codebase project tag if it's about a codebase. Feel free to correct me. :)

On enwiki the 'Mark this page as patrolled' link appears on all new pages in all namespaces not created by users with autopatrol. This is from MediaWiki-Patrolling (wgUseNPPatrol), not PageTriage and is enabled on almost all Wikimedia wikis.

That's right - however, such pages will not be shown on Special:NewPagesFeed. Only articles in Article and User namespaces will be present there.

Marking a draft as patrolled should have no impact on review with AFCH (or PageCuration if moved to mainspace).

Marking an unsubmitted draft as patrolled removes it from AfC workflow.
i.e.

  1. Draft is created -> it'll have 'Mark as patrolled' ->it appears in AfC as Unsubmitted and it does not appear in NPP (because of the Draft namespace).
  2. 'Mark as patrolled' is clicked - the draft is not visible anymore for AfC filters.

Marking a draft as patrolled should have no impact on review with AFCH (or PageCuration if moved to mainspace).

Marking an unsubmitted draft as patrolled removes it from AfC workflow.
i.e.

  1. Draft is created -> it'll have 'Mark as patrolled' ->it appears in AfC as Unsubmitted and it does not appear in NPP (because of the Draft namespace).
  2. 'Mark as patrolled' is clicked - the draft is not visible anymore for AfC filters.

This should not happen. The MediaWiki-level patrolling system is unrelated to AfC. Or maybe that's what you're saying here -- that this is a bug?

At any rate, the "mark as patrolled" link is fine, I think. AfC reviewers are used to it being there as well. We could maybe hide it somehow, but believe it or not there are (or could be) people who patrol drafts in this way but do not act as AfC reviewers. Outside the mainspace, I instinctively click this link when I see the page is in okay shape (ignoring quality of the content, just that the page doesn't need to be deleted).

Marking a draft as patrolled should have no impact on review with AFCH (or PageCuration if moved to mainspace).

Marking an unsubmitted draft as patrolled removes it from AfC workflow.
i.e.

  1. Draft is created -> it'll have 'Mark as patrolled' ->it appears in AfC as Unsubmitted and it does not appear in NPP (because of the Draft namespace).
  2. 'Mark as patrolled' is clicked - the draft is not visible anymore for AfC filters.

This should not happen. The MediaWiki-level patrolling system is unrelated to AfC. Or maybe that's what you're saying here -- that this is a bug?

At any rate, the "mark as patrolled" link is fine, I think. AfC reviewers are used to it being there as well. We could maybe hide it somehow, but believe it or not there are (or could be) people who patrol drafts in this way but do not act as AfC reviewers.

The link is fine, and there is no need to hide/remove it. If patrolling a draft removes it from the AfC queue, then that needs to be addressed in PageTriage. (i.e. Make patrol status have no impact on the AfC queue.) Patrolling should remove pages from the NPP queue. The special case is userspace since those pages can be in both queues and patrolling those should have a different effect on each queue.

kaldari claimed this task.
kaldari subscribed.

Closing this in favor of T201253 (Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts).