Page MenuHomePhabricator

Duplicated 'should should' in Phabricator:arcanist-core english messages sent for translation
Open, Needs TriagePublic

Description

Duplicated 'should should' in ENglish messages for translation

Hi all

While translating EN->FR in translatewiki.net, I detected three duplicated 'should should' in the ENglish messages for translation. Can anyone correct ? :

Phabricator:arcanist-core-39a54b410df333dd/en
Used in:ArcanistUnsafeDynamicStringXHPASTLinterRule.php:30
https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php$30
'Functions which should should not be used because they represent the unsafe usage of dynamic strings.' becomes
'Functions which should not be used because they represent the unsafe usage of dynamic strings.'

Phabricator:arcanist-core-727513c75a0ff076/en
Used in:ArcanistDeprecationXHPASTLinterRule.php:23
https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php$23
'Functions which should should be considered deprecated.' becomes 'Functions which should be considered deprecated.'

Phabricator:arcanist-core-824be53866ccd70a/fr
Used in:ArcanistUnsafeDynamicStringXHPASTLinterRule.php:24
https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/xhpast/rules/ArcanistUnsafeDynamicStringXHPASTLinterRule.php$24

'Classes which should should not be used because they represent the unsafe usage of dynamic strings.' becomes
'Classes which should not be used because they represent the unsafe usage of dynamic strings.'

Thank you.

Event Timeline

Nikerabbit added a subscriber: Nikerabbit.

Likely needs reporting upstream unless fixed already.

Thanks.
Looks not yet deployed to translatewiki.

Having the latest strings in the repository:

twn:/resources/projects/phabricator (wmf/stable)$ git grep 'should should'
projects/arcanist/core/en.json:  "39a54b410df333dd": "Functions which should should not be used because they represent the unsafe usage of dynamic strings.",
projects/arcanist/core/en.json:  "727513c75a0ff076": "Functions which should should be considered deprecated.",
projects/arcanist/core/en.json:  "824be53866ccd70a": "Classes which should should not be used because they represent the unsafe usage of dynamic strings.",
projects/arcanist/core/raw.json:  "39a54b410df333dd": "Functions which should should not be used because they represent the unsafe usage of dynamic strings.",
projects/arcanist/core/raw.json:  "727513c75a0ff076": "Functions which should should be considered deprecated.",
projects/arcanist/core/raw.json:  "824be53866ccd70a": "Classes which should should not be used because they represent the unsafe usage of dynamic strings.",
src/translations/ArcanistCoreEn.php:      'Functions which should should not be used because they represent the unsafe usage of dynamic strings.' => 'Functions which should should not be used because they represent the unsafe usage of dynamic strings.',
src/translations/ArcanistCoreEn.php:      'Functions which should should be considered deprecated.' => 'Functions which should should be considered deprecated.',
src/translations/ArcanistCoreEn.php:      'Classes which should should not be used because they represent the unsafe usage of dynamic strings.' => 'Classes which should should not be used because they represent the unsafe usage of dynamic strings.',
src/translations/ArcanistCoreFr.php:      'Functions which should should not be used because they represent the unsafe usage of dynamic strings.' => 'Fonctions qui ne devraient pas être utilisées parce qu’elles représentent l’utilisation non fiable de chaînes dynamiques.',
src/translations/ArcanistCoreFr.php:      'Functions which should should be considered deprecated.' => 'Fonctions qui doivent être considérées comme obsolètes.',
src/translations/ArcanistCoreFr.php:      'Classes which should should not be used because they represent the unsafe usage of dynamic strings.' => 'Classes qui ne devraient pas être utilisées car elles représentent l’utilisation non fiable de chaînes dynamiques.',

Ping @mmodell. If I am not mistaken we haven't enabled any new languages (like French) added in the past 6 months.

My expectation is that Release Engineering updates the Phabricator message definitions in the phabricator-i18n repository.

My expectation is that Release Engineering updates the Phabricator message definitions in the phabricator-i18n repository.

@mmodell is this update pulled in from upstream/can we call this done?

Zero results for "should should" when grep'ing the upstream codebase, but it's unclear to me how [English] strings on twn (example) get "updated"

We just pull from the wmf/stable branch of https://phabricator.wikimedia.org/source/phabricator-translations.git. How that is updated is unknown to me :)