Page MenuHomePhabricator

Allow users to change email address after first setting it
Closed, ResolvedPublic

Description

Users are only provided with a link to the email setting form once, when it's not set, and have no way of changing their email unless they navigate to the page directly.

If OAuth isn't able to find the user's email they are prompted to enter one manually, but can still check a box saying their email should be automatically updated, and aren't allowed to not enter one manually. That makes sense because we couldn't find their email from WP, but makes little sense to the user who has no idea we failed to get it automatically the first time. The change email form shouldn't allow users to both enter an email and check the box. It should be either-or to reduce confusion.

If a user has selected use_wp_email but have no email set (i.e. oauth couldn't find their email or they need to re-log), the no-email message should provide better context for this.

Event Timeline

I've updated the user page to allow users to navigate easily to the change email page, and altered the form validation to require one of either the checkbox or field to be filled.

The part I'm currently struggling with is immediately requesting an updated email through OAuth if the user selects the checkbox. Their email gets blanked because they left that field empty, but there's no obvious (that I can see) way to fire an editor data update request, besides logging the user out and back in.

Samwalton9-WMF moved this task from Doing to Open tasks on the Library-Card-Platform board.

This depends on another code change, and I'm not planning to work on it soon.

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptOct 11 2018, 10:09 AM

Instead of trying to update the email from Wikipedia on the box being checked, this change lets users know we'll update the email on file the next time they log in. Some UX modifications and a link to update email from the user page.