Parsoid HTML will be changing to use <audio> rather than <video> tags for elements wrapping audio files. In mobileapps this will require changes to the media and summary endpoints and to the anchorPopupMediaTransform (and possibly more).
Parsoid patch: https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/449903
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/services/mobileapps | master | +27 -6 | media: get ready for audio tag |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | cooltey | T193478 Some audio files not playing in the app | ||
| Resolved | BUG REPORT | Dbrant | T198504 [BUG] Audio file shows incomplete toolbar in an article page | ||
| Resolved | • bearND | T201186 Update mobileapps to handle <audio> tags |
We definitely need to change the media endpoint implementation.
TypeError: Cannot read property 'source' of undefined at _.uniq.elem (/Users/besi/de/wmf/mobileapps/lib/media.js:163:65) at Function._.uniq._.unique (/Users/besi/de/wmf/mobileapps/node_modules/underscore/underscore.js:581:33) at Object.getMediaItemInfoFromPage (/Users/besi/de/wmf/mobileapps/lib/media.js:163:14) at BBPromise.join (/Users/besi/de/wmf/mobileapps/routes/page/media.js:23:39)
Change 450896 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] media: get ready for audio tag
@Mholloway I've fixed the issues in the media endpoint.
But it's unclear what the other issues are:
Hey @bearND, the various areas I mentioned were just from grepping through the repo to see where we're using <video> tags in some way—I should probably have been more precise that they were areas needing review and possibly needing change.
I suggested an additional unit test but otherwise your patch looks good.
Change 450896 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] media: get ready for audio tag