Page MenuHomePhabricator
Create Task
Maniphest T201218

Viewing page's first revision via diff gives error
Closed, ResolvedPublic
Actions

Description

Urls of the ?title=ArticleName&diff=123456789 and ?title=ArticleName&oldid=123456789&diff=prev variety (such as from the patrol log) display an error when the referenced revision does not exist: the page title displays as "Error" and the MediaWiki:Difference-missing-revision text is displayed. The page content as of that revision ID still displays.

Example: https://en.wikipedia.org/w/index.php?title=Anglicisation_of_names&diff=prev&oldid=411729326
Compare with older MediaWiki behavior: https://rationalwiki.org/w/index.php?title=George_Tarleton&diff=prev&oldid=1730578

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.32.0-wmf.18+90 -45Fix DifferenceEngine revision loading logic
mediawiki/coremaster+90 -45Fix DifferenceEngine revision loading logic
Customize query in gerrit

Related Objects

Event Timeline

Amorymeltzer created this task.Aug 4 2018, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2018, 1:27 AM
Xiplus added a subscriber: Xiplus.Aug 4 2018, 2:25 AM
matej_suchanek merged a task: T201484: The notification for receiving thanks for the first revision of a page gives an incorrect diff URL.Aug 8 2018, 12:24 PM
matej_suchanek added a project: MediaWiki-General.
matej_suchanek added subscribers: TTO, matmarex.
TTO added a subscriber: Tgr.Aug 8 2018, 1:11 PM

Bisect points to 04f16a204b89c037a2a555615ca0cd9a66837c99 by @Tgr.

TTO edited projects, added Regression; removed MediaWiki-General, MediaWiki-Patrolling.Aug 8 2018, 1:15 PM
Tgr claimed this task.Aug 8 2018, 2:50 PM
Tgr added a project: Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).
matej_suchanek merged a task: T201221: Diff linked by the thank notification for the page creation edit displays an error message.Aug 8 2018, 2:59 PM
matej_suchanek added subscribers: SJu, Stryn, Framawiki.
Framawiki raised the priority of this task from Medium to High.Aug 8 2018, 4:37 PM

Pretty annoying bug, adds an error message where everything is good. I allow myself to increase the priority of this task.

CCicalese_WMF moved this task from MCR-SDC Storage Layer - phase 1 to MCR-SDC File Caption Support - phase 2 on the Multi-Content-Revisions board.Aug 8 2018, 5:14 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).
CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
Tgr mentioned this in T194731: Show diffs for all slots [MCR].Aug 13 2018, 1:54 PM
Tgr updated the task description. (Show Details)Aug 13 2018, 3:03 PM
Anomie added a subscriber: Anomie.EditedAug 19 2018, 12:04 AM

It looks like you changed the functions to return false in some cases where the original call returned true (versus the situation you were fixing where it returned true when the original call returned false). I left details in inline comments on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/445136.

MusikAnimal awarded a token.Aug 20 2018, 4:10 PM
MusikAnimal added a subscriber: MusikAnimal.
Sphilbrick added a subscriber: Sphilbrick.Aug 20 2018, 5:34 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 20 2018, 5:34 PM
daniel awarded a token.Aug 21 2018, 5:37 PM
Niharika added a subscriber: Niharika.Aug 21 2018, 5:53 PM
matej_suchanek merged a task: T202526: Diffs for page creation show error.Aug 22 2018, 2:55 PM
matej_suchanek added a subscriber: Daask.
gerritbot added a subscriber: gerritbot.Aug 22 2018, 9:57 PM

Change 454638 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Fix DifferenceEngine revision loading logic

https://gerrit.wikimedia.org/r/454638

gerritbot added a project: Patch-For-Review.Aug 22 2018, 9:57 PM
Daask removed a subscriber: Daask.Aug 22 2018, 10:01 PM
Tgr moved this task from In Progress to Needs Review on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 23 2018, 12:05 PM
gerritbot added a comment.Aug 24 2018, 6:24 PM

Change 454638 merged by jenkins-bot:
[mediawiki/core@master] Fix DifferenceEngine revision loading logic

https://gerrit.wikimedia.org/r/454638

Tgr closed this task as Resolved.Aug 24 2018, 6:26 PM
Sphilbrick added a comment.EditedAug 24 2018, 9:07 PM

I see this is marked as resolved.

I just looked at:
https://en.wikipedia.org/w/index.php?title=Alexandru_Dabija&diff=856373908

Revision as of 19:05, 24 August 2018 (UTC)

I'm not quite sure of the time zone associated with the "resolved" comment (Fri, Aug 24, 6:26 PM), so just checking to see if this error was created prior to the resolution.

Anomie added a comment.Aug 24 2018, 9:11 PM

The fix should be deployed to Wikimedia wikis with 1.32.0-wmf.19 or later. You can see https://www.mediawiki.org/wiki/MediaWiki_1.32/Roadmap for a schedule.

Sphilbrick added a comment.Aug 24 2018, 9:32 PM

OK, thanks

Sphilbrick added a comment.Aug 24 2018, 9:34 PM

And I feel bad, that I haven't even thanked whomever is responsible for a timely solution. Thanks, it will make the process better.

Phil

gerritbot added a comment.Aug 24 2018, 10:20 PM

Change 455254 had a related patch set uploaded (by Jforrester; owner: Gergő Tisza):
[mediawiki/core@wmf/1.32.0-wmf.18] Fix DifferenceEngine revision loading logic

https://gerrit.wikimedia.org/r/455254

CCicalese_WMF moved this task from Needs Review to Done on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 25 2018, 12:57 PM
CCicalese_WMF removed a project: Patch-For-Review.
gerritbot added a comment.Aug 27 2018, 11:19 AM

Change 455254 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.18] Fix DifferenceEngine revision loading logic

https://gerrit.wikimedia.org/r/455254

Stashbot added a subscriber: Stashbot.Aug 27 2018, 11:40 AM

Mentioned in SAL (#wikimedia-operations) [2018-08-27T11:40:08Z] <tgr@deploy1001> Synchronized php-1.32.0-wmf.18/includes/diff/DifferenceEngine.php: SWAT: [[gerrit:455254|Fix DifferenceEngine revision loading logic (T201218, T202454)]] (duration: 00m 49s)

Stashbot mentioned this in T202454: Call to a member function getRevisionRecord() on a non-object (boolean).Aug 27 2018, 11:40 AM
Yair_rand mentioned this in T203433: Viewing first revision via API gives baddiff error.Sep 4 2018, 8:01 AM
Aklapper added a project: MediaWiki-Page-History.Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL