Maniphest T201223

Split PoolCounter extension into MediaWiki core and a service repository
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Aug 4 2018, 5:18 AM

Description

The 2 PHP classes in the PoolCounter extension should be moved into MediaWiki core (along with the existing PoolCounter stuff), and the daemon should be put into a mediawiki/services/poolcounter repository.

Today there's an established pattern of having PHP code in core that depends upon a MediaWiki service (parsoid/restbase/etc.), and we also have a pattern for maintaining external services intended for use by MediaWiki.

Details

Subject	Repo	Branch	Lines +/-
poolcounter: Create PoolCounterFactory service class	mediawiki/core	master	+112 -85
Replace with a stub that extends the MediaWiki core class	mediawiki/extensions/PoolCounter	master	+3 -291
poolcounter: Merge Client and ConnectionManager from extension repo	mediawiki/core	master	+407 -5
Remove daemon, moved into a separate repository	mediawiki/extensions/PoolCounter	master	+2 -2 K

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T28751 Extensions that should really be core functionality (tracking)
Resolved		Krinkle	T201223 Split PoolCounter extension into MediaWiki core and a service repository
Resolved	Request	Krinkle	T324631 Archive the PoolCounter extension
Resolved		Zabe	T327336 Undeploy PoolCounter extension from wmf production

Event Timeline

Legoktm triaged this task as Medium priority.Aug 4 2018, 5:18 AM

Legoktm created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2018, 5:18 AM

Legoktm added a project: Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).Aug 4 2018, 5:39 AM

Requested a new repository: https://www.mediawiki.org/w/index.php?diff=2862181&oldid=2861814&title=Gerrit%2FNew_repositories%2FRequests%2FEntries&type=revision

Change 455079 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PoolCounter@master] Remove daemon, moved into a separate repository

https://gerrit.wikimedia.org/r/455079

gerritbot added a project: Patch-For-Review.Aug 24 2018, 5:13 AM

Change 455079 merged by jenkins-bot:
[mediawiki/extensions/PoolCounter@master] Remove daemon, moved into a separate repository

https://gerrit.wikimedia.org/r/455079

Legoktm moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Aug 28 2018, 7:33 PM

Krinkle moved this task from Untriaged to poolcounterd Service on the PoolCounter board.Aug 30 2018, 12:08 AM

CCicalese_WMF assigned this task to Legoktm.Oct 1 2018, 1:31 PM

CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).

CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.Oct 1 2018, 1:33 PM

CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:16 PM

CCicalese_WMF moved this task from Inbox to Needs Cleaning - Code Health (TEC13) on the Platform Engineering board.Oct 3 2018, 2:14 PM

CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.

CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 3:56 PM

Not currently working on this.

Maintenance_bot removed a project: Patch-For-Review.May 23 2019, 10:47 AM

WDoranWMF removed a project: Platform Team Workboards (Doing).Jul 5 2019, 6:33 PM

WDoranWMF removed a project: Platform Engineering (Needs Cleaning - Code Health (TEC13)).Sep 10 2019, 6:36 PM

WDoranWMF added a project: Platform Engineering.

WDoranWMF moved this task from Inbox to Icebox on the Platform Engineering board.

WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:04 PM

Krinkle added a subscriber: Krinkle.Jun 24 2022, 1:39 AM

ori added a subscriber: ori.Jun 24 2022, 2:59 AM

Krinkle edited projects, added Performance-Team; removed Platform Engineering (Icebox).Aug 8 2022, 4:51 PM

Krinkle moved this task from Inbox, needs triage to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.

Krinkle moved this task from To-do: Goals, prioritized next 4 Quarters to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Change 834401 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] poolcounter: Merge Client and ConnectionManager from extension repo

https://gerrit.wikimedia.org/r/834401

gerritbot added a project: Patch-For-Review.Sep 22 2022, 11:50 PM

Krinkle claimed this task.Sep 22 2022, 11:50 PM

Change 865206 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/PoolCounter@master] Replace with a stub that extends the MediaWiki core class

https://gerrit.wikimedia.org/r/865206

Krinkle added a subtask: T324631: Archive the PoolCounter extension.Dec 7 2022, 12:14 AM

I'm curious what's the migration guide for e.g. translatewiki.net?

In T201223#8460339, @Nikerabbit wrote:

I'm curious what's the migration guide for e.g. translatewiki.net?

Do you mean for the localisation files or for twn as a consumer? As consumer, the change is backwards-compatible since the same config vars are being used, and the extension class is retained for compatibility.

At some point after the above two changes land, at your own convenience, update LocalSettings to have class in $wgPoolCounterConf point to the new core PoolCounter Client class, instead of the extension's PoolCounter Client class which is just an empty subclass of the core one now.
After change 1, at your own convenience, remove the PoolCounter extension from your install.