Page MenuHomePhabricator
Create Task
Maniphest T201248

Photos with HTML tags on exif tags fail upload with `verification-error`
Closed, ResolvedPublic
Actions

Description

A few photos are giving us verification-error back from the commons api.
Full error message:

('verification-error', 'This file contains HTML or script code that may be erroneously interpreted by a web browser.', 'See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes.')

Some affected photos:
255234975
38025860
39548244
234853097
234851541
234852329
234854245
234858757
234856783
233511923
233511031
233515953

Related Objects

Event Timeline

Chicocvenancio created this task.Aug 4 2018, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2018, 10:40 PM
Chicocvenancio added a comment.Aug 5 2018, 2:03 AM

This seems to be due to html tags on the exif data for those photos. https://paws-public.wmflabs.org/paws/user/chicocvenancio/notebooks/T201248.ipynb

We could in theory remove or sanitize the exif data, but I would like a bit of input from the rest of the community on the best course of action here.

Chicocvenancio renamed this task from Investigate verification-error with import-500px to Photos with HTML tags on exif tags fail upload with `verification-error` .Aug 5 2018, 2:04 AM
Chicocvenancio added a comment.Aug 5 2018, 2:12 AM

The task to allow these uploads is T27707.

Chicocvenancio triaged this task as High priority.Aug 5 2018, 2:12 AM
zhuyifei1999 subscribed.Aug 5 2018, 5:05 AM
Chicocvenancio added a comment.EditedAug 5 2018, 5:18 PM

https://github.com/chicocvenancio/import-500px/commit/0f79bec31c0d71640414d5436ca8eb710901c309

Somehow html.escape is not enough. Can't quite see why, mediawiki seems to [[ https://github.com/wikimedia/mediawiki/blob/43efaf2f3f6824df3a8fb8a76beefe30489f8a32/includes/libs/mime/IEContentAnalyzer.php#L740 | only check for html tags if < is present ]].

Chicocvenancio closed this task as Resolved.Aug 5 2018, 7:24 PM

1024 ff bytes of padding does the trick https://github.com/chicocvenancio/import-500px/commit/67c5e2f53106eb525c77b9d270acb860738752ec

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits