Maniphest T201278

results in "Call to a member function staticSetup() on null"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Simetrical
	Aug 5 2018, 6:34 PM

Project Tags

Referenced Files

None

Subscribers

Description

ParserIntegrationTest has a constructor with mandatory parameters. PHPUnit wants to run it, but constructs it with no parameters, which results in a long list of notices and two failed tests. tests/phpunit/suite.xml seems to try to tell PHPUnit not to run it, but when I do

php tests/phpunit/phpunit.php tests/phpunit/includes/parser/

php tests/phpunit/phpunit.php tests/phpunit/includes/

it gets run anyway.

Is there some fix we could make to the suite.xml file? Or maybe rename it to not end in "Test" so PHPUnit ignores it by itself?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Only use "*Test.php" for actual PHPUnit tests	mediawiki/core	master	+1 -3

Customize query in gerrit

Event Timeline

Simetrical created this task.Aug 5 2018, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2018, 6:34 PM

Change 451641 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Only use "*Test.php" for actual PHPUnit tests

https://gerrit.wikimedia.org/r/451641

gerritbot added a project: Patch-For-Review.Aug 9 2018, 2:41 PM

Change 451641 merged by jenkins-bot:
[mediawiki/core@master] Only use "*Test.php" for actual PHPUnit tests

https://gerrit.wikimedia.org/r/451641

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 4 2018, 4:00 PM

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jan 25 2019, 10:59 PM

Krinkle moved this task from PHPUnit to QUnit on the MediaWiki-Core-Tests board.

Krinkle moved this task from QUnit to PHPUnit on the MediaWiki-Core-Tests board.

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:43 PM

Seems fixed.

Running PHPUnit on includes/ or includes/parser/ results in "Call to a member function staticSetup() on null"Closed, ResolvedPublicActions

Description

Details

Event Timeline

Running PHPUnit on includes/ or includes/parser/ results in "Call to a member function staticSetup() on null"
Closed, ResolvedPublic
Actions