The user shouldn't need to type while the menus are being used, and the virtual keyboard drastically reduces the amount of space available to show the menus.
It should be possible to use surfaceView.deactivate() to achieve this.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T221328 [Epic] Mobile VE usability improvements (FY18-19 Q4) | |||
| Open | None | T209505 EPIC: Fix selection issues on mobile | |||
| Resolved | Esanders | T201329 Mobile: Hide keyboard while menus are open |
Event Timeline
Comment Actions
Change 450612 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Toolbar: Emit events to let user know if toolbar popups are visible
Comment Actions
Change 450616 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Mobile: Deactivate the surface when the toolbar is active
Comment Actions
If we are confident there are no real downsides to this approach, we could actually upstream it to ve.init.Target and do it for every VE instance, desktop and mobile. This would:
- avoid any issues when using a desktop version on a mobile device (e.g. on a large tablet)
- allow users to put focusable widgets inside toolbars without losing document position
- allow users to use toolbar keyboard accessibility without losing document position
Comment Actions
I think that sounds like a good idea. I can't think of any downsides (but that doesn't mean there are none…). Should I be reviewing the current patches, or do you want to rewrite with this approach?
Comment Actions
Change 450612 merged by jenkins-bot:
[oojs/ui@master] Toolbar: Emit events to let user know if toolbar popups are visible
Comment Actions
Change 452725 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Deactivate the surface when the toolbar is active
Comment Actions
Change 450616 abandoned by Esanders:
Mobile: Deactivate the surface when the toolbar is active
Reason:
upstreamed to https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/ /452725/
Comment Actions
Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0
Comment Actions
Change 452725 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Deactivate the surface when the toolbar is active
Comment Actions
Change 453292 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aac36db2c)
Comment Actions
Change 453292 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (aac36db2c)
Comment Actions
(Copying from code review comment so it doesn't get lost)
If I have the document focussed, then click "Insert" to open the menu, then click "Insert" again to close it, I expect to have a cursor in the editing surface again. But it doesn't get focussed; I can't type until I click on it. Same problem if I click "Insert" → "Table", then Ctrl+Z to undo – I can't type until I click on the surface.
Comment Actions
Change 453430 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Reactive surface on toolbar close
Comment Actions
Thanks @matmarex, I initially though this wasn't necessary, but your use case makes sense. The above patch fixes this
Comment Actions
Ah, I remembered why I did it that way, it's because on mobile I though it would be nicer not to bring up the keyboard (which is triggered by focus) as soon as your are finished with the toolbar. That may yet prove to be the case, but any such fix for that should be in mobile-specific targets.
Comment Actions
Change 453430 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Reactivate surface on toolbar close
Comment Actions
Change 453536 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a73097d43)
Comment Actions
Change 453536 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a73097d43)
Comment Actions
Change 454013 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Blur activateElement when deactivating the surface
Comment Actions
The above patch fixes the issue on iOS (which also requires activeElement be blurred).
Comment Actions
Change 454013 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Blur activateElement when deactivating the surface
Comment Actions
Change 454168 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (510506739)
Comment Actions
Change 454168 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (510506739)
Comment Actions
This might not be relevant to this task, but can we also reactivate the surface when we close a dialog without adding anything, like pressing back on link inspector dialog/Citation dialog?