Page MenuHomePhabricator

AfC- active 'Resubmit' button on 'Submission declined' template when a draft is 'Under review'
Closed, DeclinedPublic

Description

  1. In betalabs create a draft in Draft namespace.
  2. Enable the " Yet Another AFC Helper Script" gadget and submit the draft for review - '"Review waiting" template (and appropriate categories) will be correctly added.
  3. A reviewer adds 'Under review' - the templates changes to 'Review in progress'.
  4. A reviewer declines - "Submission declined on ..." template will be added. The active button 'Resubmit' will be displayed.
  5. A creator of the draft resubmits the article - the article gets "Review waiting" template (at the bottom of the page). The Decline template does not have the active button 'Resubmit' anymore.

  1. A reviewer finds the draft awaiting for review and adds it to 'Under review' - "Review in progress" is added, but 'Declined' template displays the active 'Resubmit' button.


If 'Resubmit' button is clicked again, the 'Review waiting' is added at the bottom (not easy to notice), so the draft will have three templates - which may be very confusing to a users:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2018, 10:40 PM

I am going to check whether this is the current behavior in English Wikipedia. If it is, then we will likely not prioritize because changes to the AFCH gadget are out of scope for this project.

MMiller_WMF closed this task as Declined.Aug 7 2018, 6:37 PM

Thanks for noting this, @Etonkovidova. But this is, in fact, the behavior of the AFCH in English Wikipedia. Since we're not working on AFCH, and the gadget is behaving in the testing environments as it does in production, I'm going to close this.