Page MenuHomePhabricator
Create Task
Maniphest T201373

New Pages Feed: "created date" value changes depending on sort
Closed, ResolvedPublic
Actions

Description

One of the reviewers who was testing the New Pages Feed in the Test Wiki noticed that the prominent bold date in the upper right of a listing in the New Pages Feed can change depending on the sort. Our desired business rule is that that date is always the page's created date. This is the date to which I am referring:

image.png (86×318 px, 10 KB)

Here is how to reproduce this problem in Test Wiki:

  1. Filter the New Pages Feed to "AfC" and State = "Declined".
  2. Sort the feed by "Created date (newest)".
  3. Observe that the date for draft "Test Draft 004" reads "22:43, 11 July 2018".
  4. Sort the feed by "Submitted date (newest)".
  5. Observe that the date for draft "Test Draft 004" reads "12:55, 2 August 2018".

That date -- 12:55, 2 August 2018 -- is actually the most recent edit date on the page, which is not a date we intend to display anywhere.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/PageTriagemaster+0 -4Cleanup isReviewedSorting
mediawiki/extensions/PageTriagewmf/1.32.0-wmf.16+1 -5Always show creation date for AfC drafts
mediawiki/extensions/PageTriagemaster+1 -5Always show creation date for AfC drafts
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF triaged this task as Medium priority.Aug 7 2018, 12:03 AM
MMiller_WMF created this task.
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptAug 7 2018, 12:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson added a comment.Aug 7 2018, 3:01 PM

Definitely a feature.

Introduced by @MusikAnimal in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/442979/11/modules/ext.pageTriage.views.list/ext.pageTriage.listItem.html for the purpose of T195547: New Pages Feed: submitted date sorting option for drafts (2)

MusikAnimal added a comment.Aug 7 2018, 3:37 PM

Yes, if you are sorting by submission date it is odd to see the creation date listed instead. It will look like it isn't sorting properly. We talked about this briefly, if I remember correctly.

If you want it to always be the creation date, I think that is fine but the submission date should be listed somewhere, too.

gerritbot added a subscriber: gerritbot.Aug 7 2018, 3:41 PM

Change 451009 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Always show creation date for AfC drafts

https://gerrit.wikimedia.org/r/451009

gerritbot added a project: Patch-For-Review.Aug 7 2018, 3:41 PM
SBisson added a comment.Aug 7 2018, 3:44 PM

I've created a patch for if we decide to remove it.

We now show Submission date or Declined date when they apply on each line item so that helps but I agree that with creation date so prominent and right below the sorting options dropdown it can give the impression that it's not properly sorted.

MMiller_WMF moved this task from Inbox to Needs Discussion/Analysis on the Growth-Team board.Aug 7 2018, 5:39 PM
MMiller_WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Aug 7 2018, 5:56 PM
MMiller_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
SBisson claimed this task.Aug 7 2018, 6:02 PM
SBisson moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Aug 7 2018, 7:12 PM
gerritbot added a comment.Aug 7 2018, 8:23 PM

Change 451009 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Always show creation date for AfC drafts

https://gerrit.wikimedia.org/r/451009

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 7 2018, 9:00 PM
Etonkovidova closed this task as Resolved.Aug 9 2018, 9:27 PM

The main issue - ""created date" value changes depending on sort" - is resolved. The created date - the date that is displayed in big bold font in the upper right corner - won't change the selected order and the filter status.

Filed a follow up ticket - T201644: [betalabs] AfC - Declined date displayed as the date of the most recent draft update for the following issue:

Observe that the date for draft "Test Draft 004" reads "12:55, 2 August 2018".
That date -- 12:55, 2 August 2018 -- is actually the most recent edit date on the page, which is not a date we intend to display >anywhere.

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM
gerritbot added a comment.Aug 14 2018, 10:42 PM

Change 452856 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Always show creation date for AfC drafts

https://gerrit.wikimedia.org/r/452856

gerritbot added a comment.Aug 15 2018, 12:08 AM

Change 452856 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.16] Always show creation date for AfC drafts

https://gerrit.wikimedia.org/r/452856

Stashbot mentioned this in T199357: New Pages Feed: score draftquality on most recent revision.Aug 15 2018, 12:12 AM
Stashbot mentioned this in T201812: Running Echo as dependency of PageTriage fails unit tests.
Stashbot mentioned this in T201560: NewPagesFeed in AFC mode shows each page 4 times when all four "predicted issues" checkboxes are checked.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-08-15T00:12:14Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.16/extensions/PageTriage/: SWAT: PageTriage fixes (T199357, T201812, T201560, T201373, T201253) (duration: 00m 51s)

Stashbot mentioned this in T201253: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts.Aug 15 2018, 12:12 AM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 15 2018, 1:00 AM
gerritbot added a comment.Aug 16 2018, 1:57 PM

Change 453133 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Cleanup isReviewedSorting

https://gerrit.wikimedia.org/r/453133

gerritbot added a comment.Aug 16 2018, 2:32 PM

Change 453133 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Cleanup isReviewedSorting

https://gerrit.wikimedia.org/r/453133

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 16 2018, 3:00 PM
DannyS712 moved this task from Backlog to PageCuration & NewPagesFeed on the English-Wikipedia-New-Pages-Patrol board.Dec 2 2019, 9:13 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL