Page MenuHomePhabricator
Create Task
Maniphest T201405

Separate Language static methods/members into service(s)
Closed, ResolvedPublic
Actions

Description

One service we would want is LanguageFactory to replace Language::factory(). Two questions:

  1. Do we want to put all the other static methods on LanguageFactory, or put them in a separate service? The name suggests that it's to make Language objects, not a collection of generic Language-related methods. SpecialPageFactory does have lots of other special-page-related methods.
  1. Some of the static methods are unlikely to ever need to track state, such as isWellFormedLanguageTag(). Is it okay to leave these static? I would figure that we may as well make them instance methods as well, in case at some future date they incorporate state like caching, but it seems a bit excessive to force dependency on a service just for that.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+23 -6Deprecate Language::getMessage*For()
mediawiki/coremaster+401 -172LanguageFactory to replace Language::factory()
mediawiki/coremaster+311 -142Make LocalisationCache a service
mediawiki/coremaster+1 K -270Split some Language methods to LanguageNameUtils
mediawiki/coreREL1_34+1 K -270Split some Language methods to LanguageNameUtils
mediawiki/coremaster+384 -104New LanguageFallback service
mediawiki/coremaster+16 -32Make grammar transform cache an instance member
mediawiki/coreREL1_34+311 -142Make LocalisationCache a service
Customize query in gerrit

Related Objects
Search...

Event Timeline

Simetrical created this task.Aug 7 2018, 11:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2018, 11:58 AM
Legoktm added projects: Core-Platform-Team-Old, MediaWiki-Internationalization, I18n.Aug 7 2018, 4:13 PM
Legoktm added subscribers: Nikerabbit, TTO.

Just FYI there's also a new LanguageCode class that has some static methods related to validating language codes, I'm not sure whether isWellFormedLanguageTag() (I haven't looked at the method yet, just guessing based on the name) would belong there.

Legoktm added a subscriber: Fomafix.Aug 7 2018, 4:13 PM
CCicalese_WMF removed Simetrical as the assignee of this task.Aug 14 2018, 2:04 AM
CCicalese_WMF triaged this task as Low priority.
CCicalese_WMF moved this task from Inbox to CPT TEC13 Backlog on the Core-Platform-Team-Old board.
CCicalese_WMF added a project: Platform Team Legacy (Next).Oct 1 2018, 11:21 PM
CCicalese_WMF edited projects, added Core Platform Team Goals (Code Health (TEC13)); removed Core-Platform-Team-Old.Oct 2 2018, 12:00 AM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Core Platform Team Goals (Code Health (TEC13)).Oct 2 2018, 2:20 AM
daniel added a project: MediaWiki-Decoupling.Mar 26 2019, 2:36 PM
kchapman edited projects, added Platform Engineering (Decoupling (CDP2)); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).Mar 26 2019, 2:37 PM
CCicalese_WMF removed a project: MediaWiki-Decoupling.Mar 26 2019, 4:39 PM
gerritbot added a comment.Apr 9 2019, 8:27 AM

Change 450996 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Split Language static methods into LanguageFactory

https://gerrit.wikimedia.org/r/450996

gerritbot added a project: Patch-For-Review.Apr 9 2019, 8:28 AM
WDoranWMF removed a project: Platform Team Legacy (Next).Jul 26 2019, 5:45 PM
WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:57 PM
WDoranWMF edited projects, added Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
gerritbot added a comment.Aug 22 2019, 2:25 PM

Change 450996 abandoned by simetrical:
Split Language static methods into LanguageFactory

Reason:
This needs to be redone completely as a few separate services, as discussed.

https://gerrit.wikimedia.org/r/450996

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2019, 3:11 PM
gerritbot added a comment.Aug 25 2019, 2:02 PM

Change 450996 restored by simetrical:
Split Language static methods into LanguageFactory

https://gerrit.wikimedia.org/r/450996

gerritbot added a comment.Aug 27 2019, 10:10 AM

Change 532679 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Make LocalisationCache a service

https://gerrit.wikimedia.org/r/532679

gerritbot added a project: Patch-For-Review.Aug 27 2019, 10:10 AM

Change 532680 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Split some Language methods to LanguageNameUtils

https://gerrit.wikimedia.org/r/532680

gerritbot added a comment.Aug 27 2019, 10:18 AM

Change 532232 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] New LanguageFallback service

https://gerrit.wikimedia.org/r/532232

gerritbot added a comment.Aug 27 2019, 10:18 AM

Change 532240 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Inject grammar transform cache in Language

https://gerrit.wikimedia.org/r/532240

daniel added a project: Platform Team Workboards (Clinic Duty Team).Sep 30 2019, 3:15 PM
daniel moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Sep 30 2019, 3:15 PM

Change 532369 had a related patch set uploaded (by Daniel Kinzler; owner: simetrical):
[mediawiki/core@master] Remove Language::factory and getParentLanguage use

https://gerrit.wikimedia.org/r/532369

gerritbot added a comment.Sep 30 2019, 3:16 PM

Change 532241 had a related patch set uploaded (by Daniel Kinzler; owner: simetrical):
[mediawiki/core@master] Cache nonexistence of grammar transformations

https://gerrit.wikimedia.org/r/532241

daniel raised the priority of this task from Low to High.EditedSep 30 2019, 9:03 PM
daniel added a parent task: T231866: Circular dependency when creating service! ContentLanguage.
daniel added a project: MW-1.34-release.

Bumped to high, since this blocks T231866: Circular dependency when creating service! ContentLanguage, which we should fix for 1.34

gerritbot added a comment.Oct 7 2019, 9:01 PM

Change 532679 merged by jenkins-bot:
[mediawiki/core@master] Make LocalisationCache a service

https://gerrit.wikimedia.org/r/532679

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 7 2019, 10:00 PM
gerritbot added a comment.Oct 8 2019, 8:32 PM

Change 541624 had a related patch set uploaded (by Jforrester; owner: simetrical):
[mediawiki/core@REL1_34] Make LocalisationCache a service

https://gerrit.wikimedia.org/r/541624

gerritbot added a comment.Oct 8 2019, 9:08 PM

Change 541624 merged by jenkins-bot:
[mediawiki/core@REL1_34] Make LocalisationCache a service

https://gerrit.wikimedia.org/r/541624

gerritbot added a comment.Oct 8 2019, 9:10 PM

Change 532680 merged by jenkins-bot:
[mediawiki/core@master] Split some Language methods to LanguageNameUtils

https://gerrit.wikimedia.org/r/532680

gerritbot added a comment.Oct 8 2019, 9:52 PM

Change 541650 had a related patch set uploaded (by Ppchelko; owner: simetrical):
[mediawiki/core@REL1_34] Split some Language methods to LanguageNameUtils

https://gerrit.wikimedia.org/r/541650

ReleaseTaggerBot added a project: MW-1.34-notes.Oct 8 2019, 10:00 PM
gerritbot added a comment.Oct 8 2019, 10:58 PM

Change 532232 merged by jenkins-bot:
[mediawiki/core@master] New LanguageFallback service

https://gerrit.wikimedia.org/r/532232

gerritbot added a comment.Oct 8 2019, 10:58 PM

Change 532240 merged by jenkins-bot:
[mediawiki/core@master] Make grammar transform cache an instance member

https://gerrit.wikimedia.org/r/532240

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 8 2019, 11:00 PM
gerritbot added a comment.Oct 9 2019, 9:46 AM

Change 541650 merged by jenkins-bot:
[mediawiki/core@REL1_34] Split some Language methods to LanguageNameUtils

https://gerrit.wikimedia.org/r/541650

gerritbot added a comment.Oct 28 2019, 3:03 PM

Change 450996 merged by jenkins-bot:
[mediawiki/core@master] LanguageFactory to replace Language::factory()

https://gerrit.wikimedia.org/r/450996

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.4; 2019-10-29); removed MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 28 2019, 4:00 PM
Simetrical added a comment.Oct 28 2019, 5:58 PM

Remaining non-deprecated public static methods on Language:

  • isWellFormedLanguageTag()
  • getCodeFromFileName()
  • getMessagesFor()
  • getMessageFor()
  • getMessageKeysFor()

The getMessage() ones call the deprecated method getLocalisationCache(), and should just be deprecated. The other two are simple pure methods that are unlikely to ever need state unless we need to add caching, at which point we could move them someplace else if we want.

I think this can be resolved as soon as the getMessage*For() methods are deprecated.

gerritbot added a comment.Oct 28 2019, 6:33 PM

Change 546670 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/core@master] Deprecate Language::getMessage*For()

https://gerrit.wikimedia.org/r/546670

gerritbot added a comment.Oct 29 2019, 10:20 AM

Change 546670 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Language::getMessage*For()

https://gerrit.wikimedia.org/r/546670

Simetrical closed this task as Resolved.Oct 29 2019, 10:21 AM
Simetrical claimed this task.
WDoranWMF moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.Oct 29 2019, 3:28 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL