Page MenuHomePhabricator

Set tabindex to 1 for the search box in Timeless skin
Closed, ResolvedPublic

Description

One thing I particularly like about Vector is that it sets the tabindex to 1 for the search box, i.e. once the page is loaded, if you press the TAB button once, you will be in the search box.

Timeless does not do that, and it should.

Event Timeline

Huji created this task.Aug 7 2018, 3:41 PM
Huji moved this task from Backlog to Features on the Timeless board.

@Huji: Very handy trick and I've looked at the Vector repo, there is a slight difference with the Timeless repo in terms of structure.

There is a script at the root of the Vector skin called vector.js that is loaded in skin.json during config but in the case of timeless, the name of the script is called main.js. That's fine and if the timeless skin team intends to keep their structure, then a patch is up for review to solve this :)

Hope they want this awesome trick in the timeless skin as well as it makes UX very nice :)

Change 451613 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/skins/Timeless@master] Set tabindex to 1 for the search box in Timeless skin

https://gerrit.wikimedia.org/r/451613

xSavitar claimed this task.Aug 9 2018, 11:50 AM
xSavitar triaged this task as Medium priority.Aug 9 2018, 12:26 PM

@Huji: The jquery.tabIndex dependency doesn't use mobile as a target but this has been used in the Timeless skin and in order for us to use tabIndex as a dependency (as in Vector), we have to remove the mobile as target. See patch!

Change 451613 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Set tabindex to 1 for the search box in Timeless skin

https://gerrit.wikimedia.org/r/451613

xSavitar closed this task as Resolved.Aug 9 2018, 2:26 PM