Page MenuHomePhabricator

The notification for receiving thanks for the first revision of a page gives an incorrect diff URL
Closed, DuplicatePublic

Description

Using an alternative account, I thanked myself for the first edit of a page I created (revision 454372620). The resulting notification links to https://en.wikipedia.org/w/index.php?title=User:This,_that_and_the_other/sandbox/Schfoof&oldid=prev&diff=454372620, which is obviously invalid, because there is no previous revision.

Event Timeline

TTO created this task.Aug 8 2018, 3:30 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 8 2018, 3:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TTO added a comment.Aug 8 2018, 3:32 AM

This situation could also use a dedicated message. The current message, ‪TTO's apostrophe‬ thanked you for your edit on ‪User:This, that and the other/sandbox/Schfoof‬. could be replaced by ‪TTO's apostrophe‬ thanked you for creating the page ‪User:This, that and the other/sandbox/Schfoof‬.

matmarex added a subscriber: matmarex.

That URL is not supposed to be invalid. In older MediaWiki versions, it showed only a diff header (with no diff), but not an error message.

Here's a live example (running MW 1.29.1): https://wikiapiary.com/w/index.php?title=WikiApiary:About&oldid=7&diff=prev

In fact, here is a task that documents this behavior (and complains about it): T55299

I don't think this was an intentional change. Especially because the error message is incorrect. It says "One revision of this difference (454372620) was not found.", but revision 454372620 definitely exists, it's the other revision (with no ID) that doesn't.

TTO added a comment.Aug 8 2018, 12:56 PM

This situation could also use a dedicated message. The current message, ‪TTO's apostrophe‬ thanked you for your edit on ‪User:This, that and the other/sandbox/Schfoof‬. could be replaced by ‪TTO's apostrophe‬ thanked you for creating the page ‪User:This, that and the other/sandbox/Schfoof‬.

Filed this as T201507