Page MenuHomePhabricator
Create Task
Maniphest T201486

Exception caught when deleting a page
Closed, ResolvedPublic
Actions

Description

MediaWiki internal error.

Original exception: [4b25f3714072dbb4bbabaa1b] /w/index.php?title=User:PlavorSeol/47&action=delete_page_permanently Wikimedia\Rdbms\DBQueryError from line 1443 of /var/www/html/w/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: DELETE FROM searchindex WHERE si_page = '171'
Function: ActionDeletePagePermanently::deletePermanently
Error: 1 no such column: si_page

Backtrace:
#0 /var/www/html/w/includes/libs/rdbms/database/Database.php(1413): Wikimedia\Rdbms\Database->makeQueryException(string, integer, string, string)
#1 /var/www/html/w/includes/libs/rdbms/database/Database.php(1186): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /var/www/html/w/includes/libs/rdbms/database/Database.php(2892): Wikimedia\Rdbms\Database->query(string, string)
#3 /var/www/html/w/extensions/DeletePagesForGood/ActionDeletePagePermanently.php(86): Wikimedia\Rdbms\Database->delete(string, string, string)
#4 /var/www/html/w/extensions/DeletePagesForGood/ActionDeletePagePermanently.php(53): ActionDeletePagePermanently->deletePermanently(Title)
#5 /var/www/html/w/includes/htmlform/HTMLForm.php(662): ActionDeletePagePermanently->onSubmit(array, OOUIHTMLForm)
#6 /var/www/html/w/includes/htmlform/HTMLForm.php(554): HTMLForm->trySubmit()
#7 /var/www/html/w/includes/htmlform/HTMLForm.php(569): HTMLForm->tryAuthorizedSubmit()
#8 /var/www/html/w/includes/actions/FormAction.php(143): HTMLForm->show()
#9 /var/www/html/w/includes/MediaWiki.php(500): FormAction->show()
#10 /var/www/html/w/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#11 /var/www/html/w/includes/MediaWiki.php(867): MediaWiki->performRequest()
#12 /var/www/html/w/includes/MediaWiki.php(524): MediaWiki->main()
#13 /var/www/html/w/index.php(42): MediaWiki->run()
#14 {main}

Exception caught inside exception handler: [4b25f3714072dbb4bbabaa1b] /w/index.php?title=User:PlavorSeol/47&action=delete_page_permanently Wikimedia\Rdbms\DBTransactionStateError from line 1298 of /var/www/html/w/includes/libs/rdbms/database/Database.php: Cannot execute query from LinkBatch::doQuery (for Skin::preloadExistence) while transaction status is ERROR.
Backtrace:
#0 /var/www/html/w/includes/libs/rdbms/database/Database.php(1087): Wikimedia\Rdbms\Database->assertTransactionStatus(string, string)
#1 /var/www/html/w/includes/libs/rdbms/database/Database.php(1640): Wikimedia\Rdbms\Database->query(string, string)
#2 /var/www/html/w/includes/cache/LinkBatch.php(210): Wikimedia\Rdbms\Database->select(string, array, string, string)
#3 /var/www/html/w/includes/cache/LinkBatch.php(138): LinkBatch->doQuery()
#4 /var/www/html/w/includes/cache/LinkBatch.php(127): LinkBatch->executeInto(LinkCache)
#5 /var/www/html/w/includes/skins/Skin.php(302): LinkBatch->execute()
#6 /var/www/html/w/includes/skins/Skin.php(163): Skin->preloadExistence()
#7 /var/www/html/w/skins/Vector/includes/SkinVector.php(67): Skin->initPage(OutputPage)
#8 /var/www/html/w/includes/skins/SkinTemplate.php(224): SkinVector->initPage(OutputPage)
#9 /var/www/html/w/includes/OutputPage.php(2423): SkinTemplate->outputPage()
#10 /var/www/html/w/includes/exception/MWExceptionRenderer.php(136): OutputPage->output()
#11 /var/www/html/w/includes/exception/MWExceptionRenderer.php(53): MWExceptionRenderer::reportHTML(Wikimedia\Rdbms\DBQueryError)
#12 /var/www/html/w/includes/exception/MWExceptionHandler.php(75): MWExceptionRenderer::output(Wikimedia\Rdbms\DBQueryError, integer)
#13 /var/www/html/w/includes/exception/MWExceptionHandler.php(149): MWExceptionHandler::report(Wikimedia\Rdbms\DBQueryError)
#14 /var/www/html/w/includes/MediaWiki.php(551): MWExceptionHandler::handleException(Wikimedia\Rdbms\DBQueryError)
#15 /var/www/html/w/index.php(42): MediaWiki->run()
#16 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix support for SQLitemediawiki/extensions/DeletePagesForGoodREL1_30+1 -1
Fix support for SQLitemediawiki/extensions/DeletePagesForGoodREL1_31+1 -1
Fix support for SQLitemediawiki/extensions/DeletePagesForGoodREL1_32+1 -1
Fix support for SQLitemediawiki/extensions/DeletePagesForGoodmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• PlavorSeol created this task.Aug 8 2018, 6:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2018, 6:13 AM
• PlavorSeol removed • PlavorSeol as the assignee of this task.Aug 8 2018, 6:15 AM
• PlavorSeol added a subscriber: MediaWiki-extensions-DeletePagesForGood.
revi removed a subscriber: MediaWiki-extensions-DeletePagesForGood.Aug 20 2018, 9:30 AM
Seb35 subscribed.Dec 12 2018, 1:20 PM

@PlavorSeol: what are your versions of MediaWiki and DeletePagesForGood? And do you use MySQL or PostgreSQL? If you can, try with a recent version of DeletePagesForGood.

@Paladox: I guess this is related or perhaps even fixed by 33c0174?

Paladox added a comment.Dec 12 2018, 1:35 PM

@Seb35 i think so.

• PlavorSeol added a comment.EditedDec 12 2018, 4:39 PM

At that time, I was using one of MediaWiki 1.32.0 WMF build, and I'm currently using 1.33.0-wmf.8.
I use SQLite database.

• PlavorSeol added a comment.Dec 13 2018, 4:18 PM

@Seb35 @Paladox Still shows following error, even with latest version of DeletePagesForGood:

[874d008438c0368f80067450] /mediawiki/index.php?title=User:PlavorSeol/Test&action=delete_page_permanently Wikimedia\Rdbms\DBQueryError from line 1506 of C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: DELETE FROM searchindex WHERE si_page = '331'
Function: ActionDeletePagePermanently::deletePermanently
Error: 1 no such column: si_page

Backtrace:

#0 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(1476): Wikimedia\Rdbms\Database->makeQueryException(string, integer, string, string)
#1 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(1236): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(2954): Wikimedia\Rdbms\Database->query(string, string)
#3 C:\nginx\web\PlavorEXITBeta\mediawiki\extensions\DeletePagesForGood\ActionDeletePagePermanently.php(86): Wikimedia\Rdbms\Database->delete(string, string, string)
#4 C:\nginx\web\PlavorEXITBeta\mediawiki\extensions\DeletePagesForGood\ActionDeletePagePermanently.php(53): ActionDeletePagePermanently->deletePermanently(Title)
#5 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(663): ActionDeletePagePermanently->onSubmit(array, OOUIHTMLForm)
#6 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(555): HTMLForm->trySubmit()
#7 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(570): HTMLForm->tryAuthorizedSubmit()
#8 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\actions\FormAction.php(143): HTMLForm->show()
#9 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(501): FormAction->show()
#10 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#11 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(862): MediaWiki->performRequest()
#12 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(517): MediaWiki->main()
#13 C:\nginx\web\PlavorEXITBeta\mediawiki\index.php(42): MediaWiki->run()
#14 {main}
Paladox added a comment.EditedDec 13 2018, 4:19 PM

in the searchindex table it does have a si_page column.

see https://github.com/wikimedia/mediawiki/blob/master/maintenance/tables.sql#L1527

Did you run update.php?

• PlavorSeol added a comment.Dec 13 2018, 4:20 PM

@Paladox Currently I can't because of T211893.

Paladox added a comment.EditedDec 13 2018, 4:21 PM

@PlavorSeol if you keep running update.php it should get past that error i think :).

• PlavorSeol added a comment.EditedDec 13 2018, 4:37 PM

@Paladox I just switch to 1.33.0-alpha (which update.php works well) and ran update.php, but when I tried to delete a page permanently, still shows following error:

[dbb1ed6ad56d109713f50b7d] /mediawiki/index.php?title=User:PlavorSeol/Test&action=delete_page_permanently Wikimedia\Rdbms\DBQueryError from line 1506 of C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: DELETE FROM searchindex WHERE si_page = '331'
Function: ActionDeletePagePermanently::deletePermanently
Error: 1 no such column: si_page

Backtrace:

#0 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(1476): Wikimedia\Rdbms\Database->makeQueryException(string, integer, string, string)
#1 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(1236): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\libs\rdbms\database\Database.php(2954): Wikimedia\Rdbms\Database->query(string, string)
#3 C:\nginx\web\PlavorEXITBeta\mediawiki\extensions\DeletePagesForGood\ActionDeletePagePermanently.php(86): Wikimedia\Rdbms\Database->delete(string, string, string)
#4 C:\nginx\web\PlavorEXITBeta\mediawiki\extensions\DeletePagesForGood\ActionDeletePagePermanently.php(53): ActionDeletePagePermanently->deletePermanently(Title)
#5 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(663): ActionDeletePagePermanently->onSubmit(array, OOUIHTMLForm)
#6 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(555): HTMLForm->trySubmit()
#7 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\htmlform\HTMLForm.php(570): HTMLForm->tryAuthorizedSubmit()
#8 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\actions\FormAction.php(143): HTMLForm->show()
#9 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(501): FormAction->show()
#10 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#11 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(862): MediaWiki->performRequest()
#12 C:\nginx\web\PlavorEXITBeta\mediawiki\includes\MediaWiki.php(517): MediaWiki->main()
#13 C:\nginx\web\PlavorEXITBeta\mediawiki\index.php(42): MediaWiki->run()
#14 {main}
Paladox added a comment.Dec 13 2018, 4:41 PM

Is there searchindex in the db?

type "describe searchindex".

• PlavorSeol added a comment.EditedDec 13 2018, 4:53 PM

Yes, there is searchindex table in my database.

Paladox added a comment.Dec 13 2018, 4:55 PM

Ok then type “describe searchindex” which will tell you if you have the column”

• PlavorSeol added a comment.EditedDec 13 2018, 5:02 PM

@Paladox There are 2 columns, si_title and si_text in searchindex table.
Note: I can't use DESCRIBE command since I'm using SQLite and it doesn't support DESCRIBE command.

Paladox added a comment.Dec 13 2018, 5:26 PM
This comment was removed by Paladox.
Paladox added a comment.Dec 13 2018, 5:28 PM

I see https://github.com/wikimedia/mediawiki/blob/8e7843197e305020f35ba883fcef39a83ad1ebce/maintenance/sqlite/archives/searchindex-fts3.sql#L8

• PlavorSeol added a comment.Dec 13 2018, 10:16 PM
This comment was removed by • PlavorSeol.
• PlavorSeol added a comment.Dec 16 2018, 9:38 AM

@Paladox Could you fix it for SQLite?

gerritbot subscribed.Dec 16 2018, 11:04 PM

Change 479992 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DeletePagesForGood@master] Fix support for SQLite

https://gerrit.wikimedia.org/r/479992

gerritbot added a project: Patch-For-Review.Dec 16 2018, 11:04 PM
Paladox added a comment.Dec 16 2018, 11:04 PM

@PlavorSeol please try https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DeletePagesForGood/+/479992/ .

• PlavorSeol added a comment.Dec 17 2018, 3:31 AM

@Paladox Still shows same error. But it works well when changing like this instead of that:

		if (!( $GLOBALS['wgDBtype'] == "postgres" || $GLOBALS['wgDBtype'] == "sqlite")) {
			# Delete search index...
			$dbw->delete( 'searchindex', [ 'si_page' => $id ], __METHOD__ );
		}

When database type is SQLite, it is NOT PostgreSQL, so $GLOBALS['wgDBtype'] !== "postgres" is also true. Therefore I think that if statement returned true regardless of database type. (When database type matches one of them, another one (not equal) returns true, and they are combined with or (||))

gerritbot added a comment.Dec 19 2018, 1:02 PM

Change 479992 merged by jenkins-bot:
[mediawiki/extensions/DeletePagesForGood@master] Fix support for SQLite

https://gerrit.wikimedia.org/r/479992

gerritbot added a comment.Dec 19 2018, 1:14 PM

Change 480735 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DeletePagesForGood@REL1_32] Fix support for SQLite

https://gerrit.wikimedia.org/r/480735

gerritbot added a comment.Dec 19 2018, 1:14 PM

Change 480736 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DeletePagesForGood@REL1_31] Fix support for SQLite

https://gerrit.wikimedia.org/r/480736

gerritbot added a comment.Dec 19 2018, 1:14 PM

Change 480737 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/DeletePagesForGood@REL1_30] Fix support for SQLite

https://gerrit.wikimedia.org/r/480737

gerritbot added a comment.Dec 19 2018, 1:31 PM

Change 480735 merged by jenkins-bot:
[mediawiki/extensions/DeletePagesForGood@REL1_32] Fix support for SQLite

https://gerrit.wikimedia.org/r/480735

gerritbot added a comment.Dec 19 2018, 1:31 PM

Change 480736 merged by jenkins-bot:
[mediawiki/extensions/DeletePagesForGood@REL1_31] Fix support for SQLite

https://gerrit.wikimedia.org/r/480736

gerritbot added a comment.Dec 19 2018, 1:31 PM

Change 480737 merged by jenkins-bot:
[mediawiki/extensions/DeletePagesForGood@REL1_30] Fix support for SQLite

https://gerrit.wikimedia.org/r/480737

Paladox closed this task as Resolved.Dec 19 2018, 1:36 PM
Paladox claimed this task.

It should be fixed now! Please reopen if it is still a problem.

• PlavorSeol updated the task description. (Show Details)Jul 9 2019, 10:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits