Page MenuHomePhabricator

Mentioning someone in a footnote on StructuredDiscussions is not working
Open, Needs TriagePublic

Description

How to reproduce

  1. create a conversation or a reply on SD
  2. add a footnote using <ref shortcut
  3. use the "basic form"
  4. type on the mention button or type @

Expectation: the mention popup opens
Reality: nothing happens

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 8 2018, 1:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jQuery.Deferred exception: flowBoard.getTopicPosters is not a function TypeError: flowBoard.getTopicPosters is not a function
    at FlowVeMentionInspector.mw.flow.ve.ui.MentionInspector.initialize

Change 531949 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] MentionInspector: Don't assume the board can be found

https://gerrit.wikimedia.org/r/531949

The above patch prevents the tool from crashing, but the topic posters list is not populated.

Change 531949 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] MentionInspector: Don't assume the board can be found

https://gerrit.wikimedia.org/r/531949

The following seems to be a different issue?

In testwiki wmf.20 the following Console error is displayed:

[FLOW]  Failed to getInstanceByElement: no $container.length Arguments [jQuery.fn.init(1), callee: ƒ, Symbol(Symbol.iterator): ƒ]0: jQuery.fn.init(1)0: div.oo-ui-window.oo-ui-dialog.oo-ui-processDialog.ve-ui-fragmentInspector.oo-ui-element-hiddenlength: 1__proto__: Object(0)callee: ƒ ($el)length: 1Symbol(Symbol.iterator): ƒ values()__proto__: Object

The UI looks a slightly broken: