Maniphest T201561

Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• brion
	Aug 8 2018, 9:24 PM

Description

Steps to reproduce:

select and copy multiline text from Terminal on macOS 10.13.6
in Chrome 68.0.3440.84, open a page on mediawiki.org such as https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/VP9_transition/reports with the new wikitext editor enabled
click 'edit source'
paste

Screen Shot 2018-08-08 at 2.23.31 PM.png (522×880 px, 133 KB)

Screen Shot 2018-08-08 at 2.23.46 PM.png (1×1 px, 237 KB)

Expected behavior:

the text should paste exactly as originally, with one newline per line

Actual behavior:

every line has a blank line between it and the next line

Workaround:

use "paste and match style" instead:

Screen Shot 2018-08-08 at 2.23.52 PM.png (740×1 px, 217 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up I83b98e41: Always sanitize when using plain text paste in NWE	mediawiki/extensions/VisualEditor	master	+20 -15
	Set the plain text 'pasteSpecial' flag when using plain text paste in NWE	mediawiki/extensions/VisualEditor	master	+2 -0

Customize query in gerrit

Event Timeline

• brion created this task.Aug 8 2018, 9:24 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 8 2018, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The OSX terminal produces HTML, with each line wrapped in a <p>:

<style type="text/css">
p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 11.0px Menlo; color: #000000; background-color: #ffffff}
span.s1 {font-variant-ligatures: no-common-ligatures}
</style>

<p class="p1"><span class="s1">$ echo "Hello"</span></p>
<p class="p1"><span class="s1">Hello</span></p>

Change 549174 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Set the plain text 'pasteSpecial' flag when data.isPlainText is true in NWE

https://gerrit.wikimedia.org/r/549174

gerritbot added a project: Patch-For-Review.Nov 6 2019, 7:08 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 6 2019, 7:08 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 549174 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Set the plain text 'pasteSpecial' flag when using plain text paste in NWE

https://gerrit.wikimedia.org/r/549174

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 6 2019, 9:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2019, 9:11 PM

Change 549469 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Follow-up I83b98e41: Always sanitize when using plain text paste in NWE

https://gerrit.wikimedia.org/r/549469

gerritbot added a project: Patch-For-Review.Nov 7 2019, 2:50 PM

Change 549469 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Follow-up I83b98e41: Always sanitize when using plain text paste in NWE

https://gerrit.wikimedia.org/r/549469

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2019, 7:10 PM

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 12 2019, 8:48 PM

Ryasmeen added a project: Verified.Nov 26 2019, 11:01 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• ppelberg closed this task as Resolved.Dec 24 2019, 7:10 PM

• ppelberg claimed this task.

	F24692952: Screen Shot 2018-08-08 at 2.23.31 PM.png
	Aug 8 2018, 9:24 PM

	F24692971: Screen Shot 2018-08-08 at 2.23.46 PM.png
	Aug 8 2018, 9:24 PM

	F24692989: Screen Shot 2018-08-08 at 2.23.52 PM.png
	Aug 8 2018, 9:24 PM

Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every lineClosed, ResolvedPublicActions

Description

Details

Event Timeline

Paste from macOS Terminal to 'new wikitext editor' inserts extra newline on every line
Closed, ResolvedPublic
Actions