- Go to https://en.wikipedia.org with a desktop browser
- Create a new user
- Edit an article for the first time (maybe it was a creation, I don't remember)
The popup tip says: clicking "Save page"
The button is actually called: Publish changes
Nicolas_Raoul | |
Aug 9 2018, 8:46 AM |
F24714051: w1.PNG | |
Aug 9 2018, 8:46 AM |
The popup tip says: clicking "Save page"
The button is actually called: Publish changes
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Use "Publish changes" instead of "Save changes" | mediawiki/extensions/GuidedTour | master | +2 -2 |
Hi @Nicolas_Raoul, for future reference, please follow the instructions and provide a clear list of specific steps to reproduce.
I assume this is about GuidedTour. On an unknown wiki. :)
Looking around the GuidedTour extension, I see that the parser function {{int:...}} in the en.json (in the GuidedTour extension) takes {{int:savearticle}} instead of taking {{int:publishchanges}} and in the extension.json (for configuration), a different message key is exposed savearticle (from the core) to be used by the parser function in "ext.guidedTour.tour.firstedit".
Rather the parser function needs to feed on publishchanges ({{int:publishchanges}}) to fix this! Submitting a patch to fix this :)
"Publish changes" was introduced by WikiEditor instead of "Save changes", see here: https://www.mediawiki.org/wiki/Topic:Te6qyuexe7xbhsa9 and https://www.mediawiki.org/wiki/Topic:U7hdomv43opzwefw, seems this is a change by WMF on MediaWiki, it should be properly coordinated and probably fixed in other extensions?
Change 451617 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/GuidedTour@master] Use "Publish changes" instead of "Save changes"
Should we maintain the old savearticles message too and add a new message publishchanges for a while until all the i18n files are updated before removing the previous message completely? Or should this be done in the current patch (that is I change {{int:savearticles}} in all the language files to {{int:publishchanges}}?)
Change 451617 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] Use "Publish changes" instead of "Save changes"