Page MenuHomePhabricator

[OTRS] Fix formatting of blocked error message
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
JoeWalsh
Aug 9 2018, 7:35 PM
Referenced Files
F36855538: IMG_0483.PNG
Feb 16 2023, 5:03 PM
F36852645: preview-IMG_6132.png
Feb 15 2023, 5:06 PM
F36852643: IMG_0475.png
Feb 15 2023, 5:06 PM
F36852641: IMG_0478.png
Feb 15 2023, 5:06 PM
F36852639: IMG_0479.png
Feb 15 2023, 5:06 PM
F36852637: Spam detection.png
Feb 15 2023, 5:06 PM
F36852635: IMG_0476.png
Feb 15 2023, 5:06 PM
F36852632: IMG_0476.png
Feb 15 2023, 5:06 PM

Description

How many times were you able to reproduce it?

Didn't try - from OTRS

Steps to reproduce

  1. Attempt to login from a blocked IP address range
  2. There's no step 2

Expected results

Nicely formatted error

Actual results

blocked.png (2×1 px, 348 KB)

Design proposition

Link to Figma designs

  • Block messages show up on the screen as a modal (with red exclamationmark.octagon.fill icon) alerting the editor that they are blocked and show any other additional information found in the original message.
  • The content will be displayed so that:
    • The text is color gray-800/#202122
    • Text is left aligned
    • Font size is 15 points
    • Links are blue and underlined
    • Certain information is bold
  • Tapping 'OK' will dismiss the message.

Screen(s)

Example of an IP block
Blocked IP address.png (667×376 px, 55 KB)

Event Timeline

JMinor lowered the priority of this task from Medium to Low.May 31 2019, 6:47 PM
LGoto raised the priority of this task from Low to Medium.Sep 28 2021, 8:17 PM
LGoto added a project: ios-app-v7.0.
Tsevener subscribed.

Hi!
For the blocked message modal I have a couple questions:

  1. The loading time for the modal is multiple seconds (video below), I wonder if it is possible to decrease that time?
  1. The icon size in the designs is around 50 pts but about 100 pts in the app currently, is it possible to decrease the icon size back down to 50 pts?

In addition, the padding below the icon is really large, very slim above the icon. Is it possible to have equal padding of 24pts above and below the icon?

DesignsApp
Spam detection.png (667×375 px, 51 KB)
IMG_0476.png (667×375 px, 61 KB)
  1. The width of the modal is much wider than the width of similar modals in the app (examples below). The width of the modals below is about 280pts while the block message modal is about 338 pts wide (or if looking at the margins, the margins in the app are about 48pts left and right while with the block messages modal its about 19 pts). Could the width be the same as the other modal in the app?
AppDesigns'Your not logged in' modal'Keep saved article on device?' modal
IMG_0476.png (667×375 px, 61 KB)
Spam detection.png (667×375 px, 51 KB)
IMG_0479.png (667×375 px, 51 KB)
IMG_0478.png (667×375 px, 49 KB)
  1. The 'OK' button is below the fold and is it is not very obvious that the modal is scrollable. Is it possible to have the button stick to the bottom of the modal and additional to that would it be possible to add elements that indicate that there is information below the fold like the adding a blur & a flash of a scroller when there is information hidden? (Example below)

In addition, is it possible to keep the 'x' close icon also sticky to the top of the modal (currently is scrolls with the text)

Sticky button similar to full modalExample of flashing scroller
IMG_0475.png (667×375 px, 49 KB)
preview-IMG_6132.png (220×101 px, 15 KB)

Hi @OTichonova!

The loading time for the modal is multiple seconds (video below), I wonder if it is possible to decrease that time?

Unfortunately that's an API limitation - we only receive an error code from this API, so to turn it into fully resolved html we have to chain a followup API call to get the blocked template. So it takes twice as long as a single call to get wikitext here due to this chaining, but that extra call only occurs for blocked users, so it should be faster for others. I can look to see if caching is working properly for this template call, so that it's at least faster the 2nd+ time they trigger it.

The width of the modal is much wider than the width of similar modals in the app (examples below).

I'll look into this to get it to match more closely with the existing modals. I had changed the width logic to expand wider for iPad (it stays skinny for iPad on existing modals), and it's possible that threw things off for iPhone. I think fixing this will also shrink the icon size as well.

The 'OK' button is below the fold and is it is not very obvious that the modal is scrollable. Is it possible to have the button stick to the bottom of the modal and additional to that would it be possible to add elements that indicate that there is information below the fold like the adding a blur & a flash of a scroller when there is information hidden? (Example below)

This might be tricky because we're dipping into designing a new component - I used what we have currently out-of-the-box. But I'll see if I can find a light-touch way to adjust our panels without causing regression issues to the other panels.

Hi @Tsevener!

Unfortunately that's an API limitation...

Okay no problem, do you think it would be possible to add a progress bar or keep the 'loading state' toast (shown below) until it is fully loaded?

Toast
IMG_0483.PNG (1×744 px, 61 KB)

And sounds good about the rest, thank you for looking into the other points!

Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 17 2023, 8:22 AM
JTannerWMF claimed this task.