Page MenuHomePhabricator
Create Task
Maniphest T201646

Fix bug smashpig bug relating to IN_PROGRESS and CANCELLED_BY_CONSUMER responses
Closed, ResolvedPublic
Actions

Description

When clicking through the Ingenico Connect cancel user journey, undefined index errors are displayed.

Notice: Undefined index: createdPaymentOutput in /vagrant/srv/SmashPig/PaymentProviders/Ingenico/HostedCheckoutProvider.php on line 50

Related patches to fix the other manifestations of this bug in DonationInterface are here:

Details

SubjectRepoBranchLines +/-
Deal with status-only responses to hosted payment statuswikimedia/fundraising/SmashPigmaster+28 -1
Customize query in gerrit

Event Timeline

jgleeson created this task.Aug 9 2018, 9:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2018, 9:20 PM
jgleeson updated the task description. (Show Details)Aug 9 2018, 9:29 PM
jgleeson added a project: Fundraising Sprint Pluto is still a planet.
jgleeson updated the task description. (Show Details)Aug 9 2018, 10:11 PM
jgleeson updated the task description. (Show Details)
gerritbot subscribed.Aug 9 2018, 10:34 PM

Change 451800 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Deal with status-only responses to hosted payment status

https://gerrit.wikimedia.org/r/451800

gerritbot added a project: Patch-For-Review.Aug 9 2018, 10:35 PM
gerritbot added a comment.Aug 9 2018, 10:42 PM

Change 451800 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Deal with status-only responses to hosted payment status

https://gerrit.wikimedia.org/r/451800

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Pluto is still a planet board.Aug 9 2018, 11:18 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Pluto is still a planet board.Aug 10 2018, 4:14 AM
jgleeson moved this task from Done to Doing on the Fundraising Sprint Pluto is still a planet board.Aug 13 2018, 1:25 PM
jgleeson moved this task from Doing to Done on the Fundraising Sprint Pluto is still a planet board.Aug 13 2018, 1:41 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Aug 13 2018, 4:12 PM
• DStrine added a project: Fundraising Sprint Queue is pronounced GJif.Aug 21 2018, 8:47 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Queue is pronounced GJif board.Aug 22 2018, 1:09 AM
Ejegg closed this task as Resolved.Aug 27 2018, 5:19 PM
Ejegg triaged this task as High priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL