Maniphest T201647

Handle new CANCELLED_BY_CONSUMER Ingenico responses.
Closed, ResolvedPublic
Actions

Description

Now that we're requesting the more descriptive status in the place of IN_PROGRESS, we should handle the normalising of this status to the final status of cancelled.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Updated behaviour for FinalStatus::CANCELLED to match FinalStatus::FAILED	mediawiki/extensions/DonationInterface	master	+3 -2
	Handle CANCELLED_BY_CONSUMER getHostedCheckoutStatus() responses.	mediawiki/extensions/DonationInterface	master	+79 -31

Customize query in gerrit

Event Timeline

jgleeson created this task.Aug 9 2018, 9:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2018, 9:31 PM

Change 451786 had a related patch set uploaded (by Jgleeson; owner: Jgleeson):
[mediawiki/extensions/DonationInterface@master] Handle CANCELLED_BY_CONSUMER getHostedCheckoutStatus() responses.

https://gerrit.wikimedia.org/r/451786

gerritbot added a project: Patch-For-Review.Aug 9 2018, 9:32 PM

jgleeson moved this task from Backlog to Review on the Fundraising Sprint Pluto is still a planet board.Aug 9 2018, 9:32 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Pluto is still a planet board.Aug 9 2018, 11:18 PM

Change 451786 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Handle CANCELLED_BY_CONSUMER getHostedCheckoutStatus() responses.

https://gerrit.wikimedia.org/r/451786

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 10 2018, 12:00 AM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Pluto is still a planet board.Aug 10 2018, 4:14 AM

Looks like we need one more thing here, to do something besides show the donor a broken form. The easiest seems to be to treat the canceled status as 'failed' and show an error page which includes a 'try again' link.

jgleeson moved this task from Done to Doing on the Fundraising Sprint Pluto is still a planet board.Aug 13 2018, 1:41 PM

Change 452366 had a related patch set uploaded (by Jgleeson; owner: Jgleeson):
[mediawiki/extensions/DonationInterface@master] WIP: Updated Ingenico CANCELLED_BY_CONSUMER mapping to now map to FAILED

https://gerrit.wikimedia.org/r/452366

jgleeson moved this task from Doing to Review on the Fundraising Sprint Pluto is still a planet board.Aug 13 2018, 2:00 PM

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Aug 13 2018, 4:12 PM

Change 452366 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Updated behaviour for FinalStatus::CANCELLED to match FinalStatus::FAILED

https://gerrit.wikimedia.org/r/452366

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:54 PM

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Pluto is still a planet board.Aug 17 2018, 4:15 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Pluto is still a planet board.Aug 21 2018, 3:44 PM

• DStrine added a project: Fundraising Sprint Queue is pronounced GJif.Aug 21 2018, 8:47 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Queue is pronounced GJif board.Aug 22 2018, 1:09 AM

Ejegg closed this task as Resolved.Aug 27 2018, 5:13 PM

Ejegg triaged this task as High priority.