Page MenuHomePhabricator

Implement fluent API for Jade entity JSON
Closed, DeclinedPublic

Description

The flat interface to create judgments is gross, since we're passing unnamed parameters through PHP. We could improve on this with a fluent style, for example:

JudgmentPage::forEntity('Diff', $revId)->addJudgment(
    Judgment::forSchema('damaging')->setData(true)->setNotes($notes));

Hopefully this can be worked out before deployment.

Event Timeline

Harej triaged this task as Medium priority.Nov 14 2018, 11:46 PM
Harej renamed this task from Provide a fluent API for JADE to Provide a fluent API for Jade.Apr 15 2019, 10:25 PM
Halfak renamed this task from Provide a fluent API for Jade to Implement a fluent API for Jade.Aug 6 2019, 7:54 PM
Halfak renamed this task from Implement a fluent API for Jade to Implement fluent API for Jade entity JSON.
ACraze added a subscriber: ACraze.

Going to decline this for now. The codebase has changed considerably over the past year and this no longer really applies anymore.