Page MenuHomePhabricator
Create Task
Maniphest T201654

InvalidArgumentException "The Title object yields no ID" from Flow\LinksTableUpdater (via LinksUpdate::construct)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

The following error seems to have started appearing since php-1.32.0-wmf.15.

Query +message:InvalidArgumentException AND +LinksUpdate AND +Flow at https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-errors shows it started 2018-08-03.

So far, only on zh.wikipedia.org.

[{exception_id}] {exception_url}   InvalidArgumentException from line 119 of /srv/mediawiki/php-1.32.0-wmf.15/includes/deferred/LinksUpdate.php: The Title object yields no ID. Perhaps the page doesn't exist?

exception_id: W2rztgpAAD4AAE33jj4AAACA
exception.message: The Title object yields no ID. Perhaps the page doesn't exist?
wiki: zhwiki
url: /wiki/Special:%E5%8F%82%E6%95%B0%E8%AE%BE%E7%BD%AE (Special:Preferences)
http_method: POST

exception.trace:
#0 /srv/mediawiki/php-1.32.0-wmf.15/includes/content/AbstractContent.php(238): LinksUpdate->__construct(Title, ParserOutput, boolean)
#1 /srv/mediawiki/php-1.32.0-wmf.15/extensions/Flow/includes/LinksTableUpdater.php(35): AbstractContent->getSecondaryDataUpdates(Title)
#2 /srv/mediawiki/php-1.32.0-wmf.15/extensions/Flow/includes/Data/Listener/ReferenceRecorder.php(92): Flow\LinksTableUpdater->doUpdate(Flow\Model\Workflow)
#3 /srv/mediawiki/php-1.32.0-wmf.15/includes/deferred/MWCallableUpdate.php(34): Closure$Flow\Data\Listener\ReferenceRecorder::onAfterInsert()
#4 /srv/mediawiki/php-1.32.0-wmf.15/includes/deferred/DeferredUpdates.php(268): MWCallableUpdate->doUpdate()
#5 /srv/mediawiki/php-1.32.0-wmf.15/includes/deferred/DeferredUpdates.php(226): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#6 /srv/mediawiki/php-1.32.0-wmf.15/includes/deferred/DeferredUpdates.php(134): DeferredUpdates::execute(array, string, integer)
#7 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(913): DeferredUpdates::doUpdates(string)
#8 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(733): MediaWiki->restInPeace(string, boolean)
#9 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#10 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Ensure article ID exists before getting secondary data updatesmediawiki/extensions/Flowmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Aug 9 2018, 11:16 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald TranscriptAug 9 2018, 11:16 PM
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 9 2018, 11:17 PM
Krinkle mentioned this in T126318: InvalidArgumentException from LinksUpdate.php: "The Title object yields no ID".
Catrope moved this task from Inbox to Needs Discussion on the Growth-Team board.Aug 20 2018, 10:57 PM
Catrope mentioned this in T70526: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php.Sep 4 2018, 6:12 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 16 2018, 7:05 PM
kostajh moved this task from Needs Discussion to FY 2019-20 on the Growth-Team board.Sep 18 2018, 7:52 PM
kostajh subscribed.

Discussed in Growth team triage today, we'll get to this in Q2.

Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:20 AM
Liuxinyu970226 subscribed.Sep 27 2018, 12:18 PM
kostajh claimed this task.Nov 6 2018, 4:18 PM
kostajh edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Nov 6 2018, 9:02 PM

Change 472053 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Ensure article ID exists before getting secondary data updates

https://gerrit.wikimedia.org/r/472053

gerritbot added a project: Patch-For-Review.Nov 6 2018, 9:02 PM
kostajh added a comment.Nov 6 2018, 9:02 PM

I'm able to reproduce this by:

  1. enabling the flow beta feature on my talk page
  2. disabling it
  3. enabling it again

At the beginning of step 3 above, this code executes:

  • Flow ReferenceRecorder's onAfterInsert calls $linksTableUpdater->doUpdate( $workflow );
  • In doUpdate() there's $updates = $content->getSecondaryDataUpdates( $title );
  • That code tries to construct a new LinksUpdate object with a Title that has a DB key like {Username}/Structured_Discussions_Archive_1 with a content model of flow-board, and whose article ID is 0. LinksUpdate throws an exception. The article ID is 0 because the page has already been moved, so fetchPageRow in includes/cache/LinkCache.php doesn't find anything

As a side note, calling getSecondaryDataUpdates() is deprecated but I think that is another issue for another day.

kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 6 2018, 9:02 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 6 2018, 9:25 PM
gerritbot added a comment.Nov 6 2018, 9:35 PM

Change 472053 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Ensure article ID exists before getting secondary data updates

https://gerrit.wikimedia.org/r/472053

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 10:00 PM
Etonkovidova closed this task as Resolved.Nov 21 2018, 1:19 AM
Liuxinyu970226 unsubscribed.Nov 21 2018, 2:16 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:18 PM
Stang unsubscribed.Nov 13 2021, 10:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits