Page MenuHomePhabricator

cucumber: "$ is not defined"
Closed, ResolvedPublic

Description

13:09:24 Feature: Adding references to statements
...
13:09:35     And The copyright warning has been dismissed                    # features/step_definitions/entity_steps.rb:96
13:09:35       $ is not defined (Selenium::WebDriver::Error::JavascriptError)
13:09:35       [remote server] http://localhost:9412/jenkins-mwext-mw-selenium-composer-jessie-11995/index.php/Item:Q8?setlang=en line 69 > Function:1:in `anonymous'
13:09:35       [remote server] http://localhost:9412/jenkins-mwext-mw-selenium-composer-jessie-11995/index.php/Item:Q8?setlang=en:69:in `handleEvaluateEvent'
13:09:35       ./features/support/modules/entity_module.rb:191:in `block in wait_until_cookie_loaded'
13:09:35       ./features/support/modules/entity_module.rb:190:in `wait_until_cookie_loaded'
13:09:35       ./features/support/modules/entity_module.rb:178:in `set_copyright_ack_cookie'
13:09:35       ./features/step_definitions/entity_steps.rb:97:in `/^The copyright warning has been dismissed$/'
13:09:35       features/reference.feature:18:in `And The copyright warning has been dismissed'

https://integration.wikimedia.org/ci/job/mwext-mw-selenium-composer-jessie/11995/consoleFull

This is likely related to the recent ResourceLoader changes (T192623)

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2018, 2:07 PM

Change 451861 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] cucumber: check jquery through ResourceLoader

https://gerrit.wikimedia.org/r/451861

Now in wikibase master - let's keep an eye on this if it creates stable improvement. (not closing just yet)

Change 451861 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] cucumber: check jquery through ResourceLoader

https://gerrit.wikimedia.org/r/451861

Pablo-WMDE removed Pablo-WMDE as the assignee of this task.Aug 10 2018, 4:04 PM

Same spot, now it says "mw.cookie is undefined". Investigating...

Change 452332 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Wait for mw.cookie to be available before calling it

https://gerrit.wikimedia.org/r/452332

Change 452332 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wait for mw.cookie to be available before calling it

https://gerrit.wikimedia.org/r/452332

Change 452348 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Fix selenium wait_until_cookie_loaded

https://gerrit.wikimedia.org/r/452348

Change 452348 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix selenium wait_until_cookie_loaded

https://gerrit.wikimedia.org/r/452348

Pablo-WMDE closed this task as Resolved.Sep 19 2018, 5:32 PM