Page MenuHomePhabricator

Determine plan for Partial Blocks feature flag
Closed, ResolvedPublic

Description

As we release T190350: Epic: ⚡️ Partial blocks to production wikis we will want a feature flag to control the rollout. We'll also need to consider what will happen if a wiki wants us to temporarily (or indefinitely) disable the feature.

  • What changes need to happen to the database that will affect all wikis? Is this acceptable?
  • What should be hidden from:
    • Special:Block UI
    • Logs + Special:BlockList
    • The "you are blocked" messages that appear to users (applicable?)
  • What happens to partial blocks when the feature is "hidden" or "disabled" by the feature flag?
    • Stay in place?
    • Escalate to sitewide blocks?
    • Are we OK with Automatic vs manual clean up?

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptAug 10 2018, 8:50 PM
dmaza added a subscriber: dmaza.Aug 10 2018, 9:24 PM

To start of the conversation 😛

What changes need to happen to the database that will affect all wikis? Is this acceptable?

N/A, Database shouldn't be affected

What should be hidden from:

I think that hiding the options to create partial blocks from the UI and restricting the creation through the API should be enough. If a partial block exists after the feature has been disabled, only the option to remove it should exist. Edit should not be allowed.

What happens to partial blocks when the feature is "hidden" or "disabled" by the feature flag?

I think everything should stay the same and partial blocks should be respected until deleted or expired

Automatic or Manual cleanup should be up to whoever is disabling this. There might be only a few active partial blocks and that's easy enough to clean up manually.

aezell added a subscriber: aezell.Aug 10 2018, 9:29 PM

I agree with @dmaza.

One note is that I don't think disabling the feature should automatically delete all the existing partial blocks. It would be unfortunate if someone disables the feature not realizing that would happen. They might then be leaving the wiki open to abuse in ways they thought they had protected.

All that makes sense to me, and I agree that I don't think disabling the feature should mess with the database.

TBolliger closed this task as Resolved.Aug 28 2018, 6:46 PM
TBolliger claimed this task.
TBolliger moved this task from Ready to Done on the Anti-Harassment (AHT Sprint 27) board.

Will be done in other tasks