Page MenuHomePhabricator

Search trigger button should be hidden for assistive technology
Closed, ResolvedPublic

Description

Currently as screen reader user you're exposed to 2 buttons labelled "Search", but <button class="search-toggle"> is only triggering the search input visibility for GUI users. Therefore it should feature aria-hidden="true" attribute.

Expected outcome:

<button class="search-toggle" aria-hidden="true"></button>

Update:
In the original description probably due to a lack of sleep ;) I misstated that aria-disabled is the attribute needed, but with the input and a corresponding button side-by-side, actually aria-hidden is resolving the issue completely here. That has also been implemented in the corresponding pull request.

Event Timeline

Volker_E created this task.Aug 11 2018, 2:09 AM
Volker_E updated the task description. (Show Details)Oct 1 2018, 6:49 PM
Varnent closed this task as Resolved.Oct 1 2018, 7:11 PM
Varnent assigned this task to Volker_E.

Merged - thank you, @Volker_E! :)