Page MenuHomePhabricator

Selecting 'U.S. Federal Government' license erroneously also selects a Flickr license
Closed, ResolvedPublic

Description

I'm uploading U.S. Federal Government works (aviation accident report PDFs) to Commons. Using the Upload Wizard, I select the "This file is not my own work." and then "This work was made by the United States government" and then toggle "Original work of the US Federal Government".

When I click the "US government" option, it also opens the "The copyright holder published their photo or video on Flickr with the right license" section and toggles that US Government option as well. There is no way to un-toggle the Flickr option. If I select a different option elsewhere, the Flickr option un-toggles, but the two US Government options are tied together.

The result of this is that I have to manually delete the Flickr license (which triggers some sort of bot-based validation when added) after creating the file.

Steps to reproduce:

  1. Open the upload wizard.
  2. Select a file for upload and continue through to the "Release Rights" step
  3. Select "This file is not my own work." → "This work was made by the United States government" → "Original work of the US Federal Government"

Chrome 67.0.3396.99 on Windows 10 Home.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks for reporting this and welcome to Wikimedia Phabricator!
Confirming on https://test.wikipedia.org/wiki/Special:UploadWizard

Change 452678 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Make sure only 1 radio, even if another has the same value, is selected

https://gerrit.wikimedia.org/r/452678

Change 452678 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Make sure only 1 radio, even if another has the same value, is selected

https://gerrit.wikimedia.org/r/452678

@AlexisJazz: If you can still reproduce the problem, please provide steps to reproduce the problem. Thanks.

@AlexisJazz: This fix should be live.
I just tested (on beta commons) and it didn't apply the {{flickrreview}} template when selecting "Original work of the US Federal Government" from "This work was made by the United States government", but it did add the template when I selected that option from "The copyright holder published their photo or video on Flickr with the right license".
So it appears to be working, as far as I can see.

I accidently did something the edit before.Sorry.

@Aklapper from https://commons.wikimedia.org/wiki/Commons:Administrators%27_noticeboard/Archive_70#Possible_problems_with_User:FlickreviewR_2_bot%3F

"Ok. So I just uploaded File:Test upload 12345.png for shits and giggles. When you select Original work of the US Government it automatically opens another drop down menu and automatically selects The copyright holder published their photo or video on Flickr with the right license. There does not appear to be an option for deselecting the Flickr option. Collapsing the menu does not deselect it, although selecting a Work of NASA does deselect it. So it's applying one PD-US-Gov tag for the "work of US gov" and applying a second one along with the Flickr tag for the Flickr option that you cannot deselect. The only way I see to upload PD-US-Gov with the wizard is to manually type PD-US-Gov. GMGtalk 20:14, 21 August 2018 (UTC)"

@matthiasmullie a patch being applied on beta Commons is not what I would personally call "live", but maybe I'm confused by developer jargon. What is the word for the patch being applied to not-beta Commons? Rolled out? Has it not been rolled out yet?

I think I phrased that the wrong way: the fix *is* live (in production).
I tested the entire upload routine on beta & it works as expected.
I also tested the relevant part on Commons (selecting 1 option no longer automatically selects the other) and that seemed to work; I just didn't actually submit the garbage image to Commons.

So as far as I can tell, this works. The steps from August 21 can no longer be reproduced - not for me at least. Can anyone else reproduce?

I I have a good test failure. Last night I posted this: [[File:M718A1_draw-2.2.png]]. First it put this up: {{flickrreview}}{{PD-USGov}}. (Note that there was only one {{PD-USGov}}, before two were showing up). This morning I have this: [https://commons.wikimedia.org/w/index.php?title=File%3AM718A1_draw-2.2.png&type=revision&diff=318987704&oldid=318963378].

I am using macOS High Sierra v. 10-13-6 in Firefox Quantum Update to 62.0

Upload wizard. Choose file, upload, fill out source, author, and a blurb. Flikr tab was open and US Govt. was checked. Right below that another US Govt. checked. That was default (I regularly do US Govt.). Date, category, publish. I did nothing more.

Hope I got the test right this time.

I just got this. Sorry for my style, not my turf.

  1. 2 License default: [[File:Test 2.5.tif]]
  2. 3 Ender description and date: [[File:Test 3.5.tif]]
  3. 4 Download complete: [[File:Test 4.tif]]
  4. 5 Flagged [[File:Test 5.5.tif]]
  5. 6 Edit: [[File:Test 6.6.tif]]

(Note: none of my uploads in the last week are important)

Darn. I forgot the first part of the License: [[File:Test_1.5.tif]] and the image itself: File:M151A1_under_1.tif

Could it have spotted me specifically? It doesn't default to USGovt for
everybody, does it? I always do USGovt. I have never used Flickr, though.

I have a Upload Wizard preference checked "US Federal Government" (my only check). That is why the US Government tab opens? But the Flikr tab should not open and {{FlickreviewR...}}{{PD-USGov}} should not be added? Please tell me when to shut up. Thank you.

The Upload Wizard preference "Someone else's work - Original work of the US Federal Government" may be the problem. If I de-select it I can walk through the upload step by step and not get flagged. If this problem only affects me I am sorry to waste your time. Thank you.

Change 462505 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462505

@SDIII thanks for the help, probably wouldn't have thought of the user preferences causing this.
I have a patch up that should fix this soon.

https://commons.wikimedia.org/w/index.php?title=File:Commissaris_van_de_Koning_ZH_Jaap_Smit.jpg&diff=321675456&oldid=321675402

New user uploads a file with UploadWizard with this license:

{{cc-by-sa-4.0}}{{flickrreview}}{{cc-by-2.0}}

How is that even possible? Sure you can select "The copyright holder published their photo or video on Flickr with the right license", but where does the cc-by-sa-4.0 come from in that case?

That option ("copyright holder published on Flickr") is missing an option for CC0 btw..

Change 462505 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462505

Change 462780 had a related patch set uploaded (by Jforrester; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@wmf/1.32.0-wmf.23] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462780

Change 462781 had a related patch set uploaded (by Jforrester; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@wmf/1.32.0-wmf.22] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462781

Change 462780 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.32.0-wmf.23] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462780

Change 462781 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.32.0-wmf.22] Tweak some default license inconsistencies

https://gerrit.wikimedia.org/r/462781

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This should now be fixed in production. Sorry about the bug.