Page MenuHomePhabricator

[regression] Layout issues in feedback dialog
Closed, ResolvedPublic1 Estimated Story Points

Description

The labels "Subject:" and "Message:" are too close to their respective text boxes, and there label for the consent checkbox doesn't align with the checkbox itself. The problem is also present in the upload dialog.

Event Timeline

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

The field alignment looks like it's just some width values that need to be tweaked for ongoing OOUI padding creep.

Change 452705 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/core@master] Feedback form: tweak field spacing

https://gerrit.wikimedia.org/r/452705

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 1.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

That is indeed the cause. Specifically, the feedback dialog puts a <p> element into the label, and I didn't expect block elements to appear inside it…

Unfortunately it doesn't seem like I can just blame it for the problem, because a similar pattern exists elsewhere, e.g. the upload dialog:

Change 452737 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Revert "FieldLayout: Avoid unclickable gap between widget and label in 'inline' align"

https://gerrit.wikimedia.org/r/452737

Change 452737 merged by jenkins-bot:
[oojs/ui@master] Revert "FieldLayout: Avoid unclickable gap between widget and label in 'inline' align"

https://gerrit.wikimedia.org/r/452737

Change 452705 merged by jenkins-bot:
[mediawiki/core@master] Feedback form: tweak field spacing

https://gerrit.wikimedia.org/r/452705

Change 452872 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Volker_E edited projects, added OOUI (OOUI-0.28.0); removed OOUI.

Change 452872 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.28.0

https://gerrit.wikimedia.org/r/452872

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

The OOUI release landed in MediaWiki 1.32.0-wmf.18.

@Ryasmeen Would you mind looking at this and verify?

@Volker_E: Verified, seems fixed on both the dialogs.