Maniphest T201879

Remove articles from reading lists does not remove the articles' offline data
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cooltey
	Aug 13 2018, 10:46 PM

Description

From the OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10777736

Hello, I've noticed that the user data for Reading Lists on the Wikipedia app won't erase. For example, I have 9 articles saved to my device for a total of 10.7mb. However, the device storage report shows that the app has accumulated 58.44mb of data. Even if I delete my entire reading history and clear the app cache, this remains unchanged except for increasing every time I add an article to a reading list. As such, my guess is that when I remove an article from a reading list the data remains on my device. Is this a bug? Where can I find this surplus data to manually erase it?

Pixel 2, Android 8.1

Jake Goodman

Steps to reproduce

Open the Android app usage screen to monitor the Wikipedia app usage.
In the Wikipedia app, try to add articles to a new reading list
Check the Wikipedia app usage
Back to the Wikipedia app and delete the reading list.
Check the Wikipedia app usage again.

Screenshot_1534200286.png (1×1 px, 87 KB)

Expected

The articles' offline data should be removed if they are not in any reading list.

Actual

The offline data keeps in the app as an "User data"

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix: Remove articles from reading lists does not remove the articles' offline data	apps/android/wikipedia	master	+58 -2

Customize query in gerrit

Related Objects

Mentioned In: T209115: Add a feature to clean up all the cache and offline data
Mentioned Here: T191550: [BUG] Showing incorrect cache contents when switching Chinese variants

Event Timeline

cooltey created this task.Aug 13 2018, 10:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2018, 10:46 PM

Liuxinyu970226 added projects: Android-app-Bugs, Wikipedia-Android-App-Backlog.Aug 14 2018, 1:30 AM

Liuxinyu970226 removed a subscriber: Android-app-Bugs.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog.Aug 21 2018, 4:05 PM

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme). · View Herald TranscriptAug 21 2018, 4:05 PM

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog.Aug 21 2018, 4:05 PM

cooltey claimed this task.Sep 6 2018, 11:35 PM

cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.

cooltey moved this task from Doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Sep 10 2018, 4:28 PM

cooltey removed cooltey as the assignee of this task.Sep 10 2018, 5:25 PM

@cooltey I cannot reproduce this. In my testing, the offline cache files are correctly deleted.

@Dbrant

I keep following the test steps below for 4 times:

Login my account, it has 4 lists with 48 articles
Logout
Go to Settings -> Clear cache
Monitor the app storage

(1st)

Screenshot_1537377819.png (1×1 px, 87 KB)

(2nd)

Screenshot_1537378175.png (1×1 px, 88 KB)

(3rd)

Screenshot_1537378436.png (1×1 px, 89 KB)

(4th)

Screenshot_1537379260.png (1×1 px, 87 KB)

As you can see, the User data keeps increasing (except the 2nd run)

In the Device file explorer, the cache -> okhttp-cache will be cleared if we tap on Clear cache in Settings.

wikipedia____Documents_Android_wikipedia__-_____app_src_main_java_org_wikipedia_readinglist_ReadingListFragment_java__app_.png (1×1 px, 293 KB)

The files -> okhttp-cache will still have cache files, but not sure what's the difference between the files in cache folder.

(The usage of User data will decrease after removing the okhttp-cache folder in files.

Screenshot_1537379675.png (1×1 px, 87 KB)

cooltey claimed this task.Oct 26 2018, 3:38 PM

cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.

@Dbrant
I found the issue may be related to this ticket T191550

If the lists contain Chinese articles, and the cache data of these articles will not be deleted properly.

But I am not sure whether the OTRS user is a Chinese user or he/she read Chinese, maybe it would possibly happen in other languages.

Update: the user who reported the issue said the articles in the lists were from English Wikipedia.

Change 470949 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Fix: Remove articles from reading lists does not remove the articles' offline data

https://gerrit.wikimedia.org/r/470949

gerritbot added a project: Patch-For-Review.Oct 31 2018, 11:25 PM

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Oct 31 2018, 11:45 PM

Change 470949 abandoned by Cooltey:
Fix: Remove articles from reading lists does not remove the articles' offline data

Reason:
Solved

https://gerrit.wikimedia.org/r/470949

Note: should be related to this patch: https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/+/472445/

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Nov 8 2018, 9:34 PM

cooltey mentioned this in T209115: Add a feature to clean up all the cache and offline data.Nov 8 2018, 9:40 PM

Works for me on 2.7.266-alpha-2018-11-27

Dbrant closed this task as Resolved.Nov 29 2018, 4:19 PM

	F26067981: wikipedia____Documents_Android_wikipedia__-_____app_src_main_java_org_wikipedia_readinglist_ReadingListFragment_java__app_.png
	Sep 19 2018, 6:03 PM

Remove articles from reading lists does not remove the articles' offline dataClosed, ResolvedPublicActions