Page MenuHomePhabricator

Request for &rvdiffprop in &prop=revisions to fetch diff info (size)
Closed, DeclinedPublic


Author: herd

It would be useful to be able to return the size of a diff and/or cache status before actually preloading it via the browser. For example:

This generates 168k gzipped, but in actuality it is 5.5 megs plaintext.

With &rvdiffinfo it would be nice, if the diff is already cached, to show the size (and possibly titles, cache key, other diff info) without necessarily fetching it.

I am ambivalent on whether it would be a good idea to return the info if the diff is not cached, as that would involve generating it, and might be a bad practice (that they could then generate huge diffs without having to download them). Probably if it is not cached, the user should get a cached=false or notcached="" parameter, so they know they must &rvdiffto to generate it first.

Version: 1.15.x
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:32 PM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz18189.
bzimport added a subscriber: Unknown Object (MLST).

I wonder if there is any relation to (fixed) for user contribs and if that fixed one would make it easier to implement this request here?

Anomie closed this task as Declined.May 4 2017, 7:27 PM
Anomie added a subscriber: Anomie.

Per T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase, diffing in prop=revisions is deprecated.

Change 352191 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Rewrite ApiComparePages

Change 352191 merged by jenkins-bot:
[mediawiki/core@master] API: Rewrite ApiComparePages