Maniphest T201901

Selenium test Lexeme:Undoing removes grammatical features fails
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Nikerabbit
	Aug 14 2018, 8:26 AM

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/10604/console

Session ID: fe3ced057244a4a6605bf2d9008be9e4
Spec: /workspace/src/extensions/WikibaseLexeme/tests/selenium/specs/lexeme.undo.js
Running: chrome
08:22:26 [chrome #0-12]
  Lexeme:Undoing
08:22:26 [chrome #0-12]
  Lexeme:Undoing
      1) removes grammatical features
08:22:26 [chrome #0-12]
08:22:26 [chrome #0-12]
1 failing (7s)
08:22:26 [chrome #0-12]
1) Lexeme:Undoing removes grammatical features:
unknown error: Element <button type="submit" tabindex="0" aria-disabled="false" title="Save your changes [alt-shift-s]" accesskey="s" name="wpSave" value="Save page" class="oo-ui-inputWidget-input oo-ui-buttonElement-button webfonts-changed">...</button> is not clickable at point (270, 435). Other element would receive the click: <div class="oo-ui-window oo-ui-dialog oo-ui-messageDialog ve-init-mw-desktopArticleTarget-windowManager ve-init-mw-desktopArticleTarget-windowManager-welcome oo-ui-window-active oo-ui-window-setup" role="dialog" aria-labelledby="ooui-1">...</div>
Error: An unknown server-side error occurred while processing the command.
    at UndoPage.save (extensions/WikibaseLexeme/tests/selenium/pageobjects/undo.page.js:10:19)
    at Context.it (extensions/WikibaseLexeme/tests/selenium/specs/lexeme.undo.js:58:12)
    at Promise.F (node_modules/core-js/library/modules/_export.js:36:28)
    at elementIdClick("0.30583878450832236-1") - click.js:20:22
08:22:26 [chrome #0-12]

Details

Subject	Repo	Branch	Lines +/-
selenium: undo page	mediawiki/core	master	+37 -0
Replace browser test with integration test	mediawiki/extensions/WikibaseLexeme	master	+73 -74
Dismiss Visual Editor modal before undoing lexeme changes	mediawiki/extensions/WikibaseLexeme	master	+3 -0
DNM Debugging T201901	mediawiki/extensions/ContentTranslation	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWLE2bf92fef4f9b: Replace browser test with integration test
rEWLEd4de2c234c52: Replace browser test with integration test
rEWLE79ee5a301edc: Replace browser test with integration test
rEWLEdbd599065c2f: Replace browser test with integration test
rEWLE74d8cd978d68: Replace browser test with integration test
T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make
rEWLEc7f9ece34e7d: Dismiss Visual Editor modal before undoing lexeme changes
Mentioned Here: T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make
T185944: OOUI window ready process runs before window is actually ready (Category drop down list gets sticky when it's open while closing the dialog)
T200508: Run WikibaseLexeme tests with Wikibase CI

Event Timeline

Nikerabbit created this task.Aug 14 2018, 8:26 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptAug 14 2018, 8:26 AM

Marking UBN! because this blocks ContentTranslation merges.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptAug 14 2018, 8:27 AM

This will again be as a result of T200508 being completed yesterday

Addshore added a project: ContentTranslation.Aug 14 2018, 11:54 AM

Addshore moved this task from incoming to other stuff on the Wikidata Lexicographical data board.

Addshore added subscribers: Lucas_Werkmeister_WMDE, Tarrow.

Jakob_WMDE subscribed.Aug 14 2018, 11:55 AM

From the screenshot it looks like a “welcome to $wiki” banner is blocking the “submit” button:

ERROR_chrome_2018-08-14T08-22-26.153Z.png (899×1 px, 78 KB)

That’s the VisualEditor welcome (i18n) – VE probably shouldn’t be running on that page, should it?

In T201901#4501196, @Lucas_Werkmeister_WMDE wrote:

That’s the VisualEditor welcome (i18n) – VE probably shouldn’t be running on that page, should it?

I agree it probably shouldnt be showing that prompt on the undo page? that could be desired though?

I get the same dialog on Wikidata in a private window, so it must not be a very recent change.

Screenshot_2018-08-14 Undoing edit to Q4115189 - Wikidata.png (1×1 px, 81 KB)

In T201901#4501182, @Addshore wrote:

This will again be as a result of T200508 being completed yesterday

So, it appears this is indeed because Wikibase now pulls in Lexeme for CI, and ContentTranslation pulls in Wikibase (thus also Lexeme).
ContentTranslation also pulls in VisualEditor, which Wikibase and WikibaseLexeme do not, hence why this VE popup only gets in the way of the ContentTranslation CI.

from parameter_functions.py

'ContentTranslation': ['Echo', 'EventLogging', 'GuidedTour',
                       'UniversalLanguageSelector', 'Wikibase',
                       'VisualEditor'],
'Wikibase': [
    'CirrusSearch',
    'cldr',
    'Elastica',
    'GeoData',
    'Scribunto',
    'Capiunto',
    'Echo',
    'PropertySuggester',
    'WikibaseQuality',
    'WikibaseQualityConstraints',
    'WikimediaBadges'
],

In T201901#4501203, @Lucas_Werkmeister_WMDE wrote:

I get the same dialog on Wikidata in a private window, so it must not be a very recent change.

A recent change did happen https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/441490/ T185944

But that is still 1 month ago.

Jakob_WMDE claimed this task.Aug 14 2018, 12:08 PM

Change 452666 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Dismiss Visual Editor modal before undoing lexeme changes

https://gerrit.wikimedia.org/r/452666

gerritbot added a project: Patch-For-Review.Aug 14 2018, 1:02 PM

Jakob_WMDE mentioned this in rEWLEc7f9ece34e7d: Dismiss Visual Editor modal before undoing lexeme changes.Aug 14 2018, 1:03 PM

Change 452667 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/ContentTranslation@master] DNM Debugging T201901

https://gerrit.wikimedia.org/r/452667

Change 452667 abandoned by Jakob:
DNM Debugging T201901

https://gerrit.wikimedia.org/r/452667

Jakob_WMDE mentioned this in T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make.Aug 14 2018, 2:16 PM

Change 452677 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/core@master] selenium: undo page

https://gerrit.wikimedia.org/r/452677

Change 452666 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Dismiss Visual Editor modal before undoing lexeme changes

https://gerrit.wikimedia.org/r/452666

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 3:00 PM

• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.Aug 14 2018, 3:20 PM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration5 board.

How does this relate to T201928? The above patches mention dismissing the dialogue, so will fixing this one also fix the other task? Should they be merged? Some guidance would be appreciated. :-)

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:52 PM

WMDE-leszek subscribed.Aug 15 2018, 7:16 AM

@Deskana I believe we hope the other one. I.e. that fixing T201928 would also fix this one :) Basically T201928 is a bug, and what this task covers is more of the influence of this bug.

Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and by whom), than let's do it!

In T201901#4504210, @WMDE-leszek wrote:

Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and by whom), than let's do it!

I agree they shouldn't be merged, there are multiple ways to solve this immediate blocking CI issue, we could stop running lexeme tests with Content Translation again for example, but we really don't want to, or add a hack to dismiss the popup that should not be there. But of course the dream would be for T201928 to be solved within VE.

Change 452915 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test

https://gerrit.wikimedia.org/r/452915

Jakob_WMDE mentioned this in rEWLE74d8cd978d68: Replace browser test with integration test.Aug 15 2018, 10:40 AM

Jakob_WMDE mentioned this in rEWLEdbd599065c2f: Replace browser test with integration test.Aug 15 2018, 10:43 AM

Jakob_WMDE mentioned this in rEWLE79ee5a301edc: Replace browser test with integration test.Aug 15 2018, 10:54 AM

Jakob_WMDE mentioned this in rEWLEd4de2c234c52: Replace browser test with integration test.Aug 15 2018, 12:07 PM

Jakob_WMDE mentioned this in rEWLE2bf92fef4f9b: Replace browser test with integration test.Aug 15 2018, 12:18 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration5 board.Aug 15 2018, 1:05 PM

Change 452915 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace browser test with integration test

https://gerrit.wikimedia.org/r/452915

With https://gerrit.wikimedia.org/r/452915 merged the T201928 should no longer be triggering failures that were blocking ContrentTranslation. @Nikerabbit could you verify that this is the case (and at very least lower the priority of this task, although probably is could be even claimed resolved now).

T201928 remains an open bug in VE.

I haven't seen this blocking anymore.

Change 452677 merged by jenkins-bot:
[mediawiki/core@master] selenium: undo page

https://gerrit.wikimedia.org/r/452677

Arrbee moved this task from Needs Triage to Check & Move on the ContentTranslation board.Aug 20 2018, 10:08 AM

Arrbee moved this task from Check & Move to Upstream/Other teams on the ContentTranslation board.Aug 20 2018, 2:04 PM

WMDE-leszek added a project: Wikidata-Editor-Experience-Improvements-Iteration6.Aug 22 2018, 9:20 AM

WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration6 board.Aug 22 2018, 9:23 AM

• Petar.petkovic removed a project: Patch-For-Review.Aug 24 2018, 9:36 AM

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Editor-Experience-Improvements-Iteration6 board.Aug 29 2018, 1:00 PM

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Aug 29 2018, 1:01 PM

• Pablo-WMDE closed this task as Resolved.Aug 29 2018, 1:01 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 29 2018, 1:01 PM

Liuxinyu970226 unsubscribed.Aug 31 2018, 12:07 AM

	F24923831: Screenshot_2018-08-14 Undoing edit to Q4115189 - Wikidata.png
	Aug 14 2018, 12:03 PM

	F24923387: ERROR_chrome_2018-08-14T08-22-26.153Z.png
	Aug 14 2018, 11:56 AM

Selenium test Lexeme:Undoing removes grammatical features failsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Selenium test Lexeme:Undoing removes grammatical features fails
Closed, ResolvedPublic
Actions