Session ID: fe3ced057244a4a6605bf2d9008be9e4 Spec: /workspace/src/extensions/WikibaseLexeme/tests/selenium/specs/lexeme.undo.js Running: chrome 08:22:26 [chrome #0-12] Lexeme:Undoing 08:22:26 [chrome #0-12] Lexeme:Undoing 1) removes grammatical features 08:22:26 [chrome #0-12] 08:22:26 [chrome #0-12] 1 failing (7s) 08:22:26 [chrome #0-12] 1) Lexeme:Undoing removes grammatical features: unknown error: Element <button type="submit" tabindex="0" aria-disabled="false" title="Save your changes [alt-shift-s]" accesskey="s" name="wpSave" value="Save page" class="oo-ui-inputWidget-input oo-ui-buttonElement-button webfonts-changed">...</button> is not clickable at point (270, 435). Other element would receive the click: <div class="oo-ui-window oo-ui-dialog oo-ui-messageDialog ve-init-mw-desktopArticleTarget-windowManager ve-init-mw-desktopArticleTarget-windowManager-welcome oo-ui-window-active oo-ui-window-setup" role="dialog" aria-labelledby="ooui-1">...</div> Error: An unknown server-side error occurred while processing the command. at UndoPage.save (extensions/WikibaseLexeme/tests/selenium/pageobjects/undo.page.js:10:19) at Context.it (extensions/WikibaseLexeme/tests/selenium/specs/lexeme.undo.js:58:12) at Promise.F (node_modules/core-js/library/modules/_export.js:36:28) at elementIdClick("0.30583878450832236-1") - click.js:20:22 08:22:26 [chrome #0-12]
- Mentioned In
- rEWLE2bf92fef4f9b: Replace browser test with integration test
rEWLEd4de2c234c52: Replace browser test with integration test
rEWLE79ee5a301edc: Replace browser test with integration test
rEWLEdbd599065c2f: Replace browser test with integration test
rEWLE74d8cd978d68: Replace browser test with integration test
T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make
rEWLEc7f9ece34e7d: Dismiss Visual Editor modal before undoing lexeme changes
- Mentioned Here
- T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make
T185944: OOUI window ready process runs before window is actually ready (Category drop down list gets sticky when it's open while closing the dialog)
T200508: Run WikibaseLexeme tests with Wikibase CI
So, it appears this is indeed because Wikibase now pulls in Lexeme for CI, and ContentTranslation pulls in Wikibase (thus also Lexeme).
ContentTranslation also pulls in VisualEditor, which Wikibase and WikibaseLexeme do not, hence why this VE popup only gets in the way of the ContentTranslation CI.
'ContentTranslation': ['Echo', 'EventLogging', 'GuidedTour', 'UniversalLanguageSelector', 'Wikibase', 'VisualEditor'], 'Wikibase': [ 'CirrusSearch', 'cldr', 'Elastica', 'GeoData', 'Scribunto', 'Capiunto', 'Echo', 'PropertySuggester', 'WikibaseQuality', 'WikibaseQualityConstraints', 'WikimediaBadges' ],
Re merging I am note sure. Could be done, although there is some "conceptual" difference, as I tried to say in the last sentence in the row above. If merging tasks makes it easier to manage and figure out what should be fixed (and by whom), than let's do it!
I agree they shouldn't be merged, there are multiple ways to solve this immediate blocking CI issue, we could stop running lexeme tests with Content Translation again for example, but we really don't want to, or add a hack to dismiss the popup that should not be there. But of course the dream would be for T201928 to be solved within VE.
With https://gerrit.wikimedia.org/r/452915 merged the T201928 should no longer be triggering failures that were blocking ContrentTranslation. @Nikerabbit could you verify that this is the case (and at very least lower the priority of this task, although probably is could be even claimed resolved now).
T201928 remains an open bug in VE.