Page MenuHomePhabricator
Create Task
Maniphest T201902

Make taint-check-plugin known about HTMLInfoField 'rawrow' option
Closed, ResolvedPublic
Actions

Description

The HTMLInfoField has a 'rawrow' option.

In my opinion this includes the existing 'raw' option and the taint-check-plugin should known about it.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Treat htmlform type=info's 'rawrow' option like 'raw'Brian Wolffmediawiki/tools/phan/SecurityCheckPluginmaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Aug 14 2018, 9:01 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptAug 14 2018, 9:01 AM
Umherirrender renamed this task from Teach taint-check-plugin about HTMLInfoField 'rawrow' option to Make taint-check-plugin known about HTMLInfoField 'rawrow' option.Aug 14 2018, 9:46 AM
Umherirrender updated the task description. (Show Details)
Legoktm moved this task from Backlog to MediaWiki mode on the phan-taint-check-plugin board.Aug 17 2018, 7:03 AM
Umherirrender mentioned this in T202365: Add phan-taint-check-plugin to SecurePoll extension.Aug 21 2018, 9:22 AM

I have leave comments about this task in BetaFeatures extension and Gadgets extensions which should be removed once this is fixed and a new version is ready.

Umherirrender mentioned this in T202372: Add phan-taint-check-plugin to CentralNotice extension.Aug 21 2018, 10:25 AM
gerritbot subscribed.Sep 4 2018, 6:27 PM

Change 457962 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Treat htmlform type=info's 'rawrow' option like 'raw'

https://gerrit.wikimedia.org/r/457962

gerritbot added a project: Patch-For-Review.Sep 4 2018, 6:27 PM
gerritbot added a comment.Sep 6 2018, 5:27 AM

Change 457962 merged by jenkins-bot:
[mediawiki/tools/phan/SecurityCheckPlugin@master] Treat htmlform type=info's 'rawrow' option like 'raw'

https://gerrit.wikimedia.org/r/457962

Bawolff closed this task as Resolved.Sep 7 2018, 7:20 PM
Bawolff claimed this task.
sbassett moved this task from MediaWiki mode to Done on the phan-taint-check-plugin board.Oct 15 2019, 6:56 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 7:17 PM
sbassett triaged this task as Medium priority.Oct 15 2019, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits