T140804 removed support for global LESS variables.
Unfortunately it seems there were some usages in Minerva inside gallery (Special:Uploads), notifications overlay and Special:MobileOptions which were not picked up by CI (why!?)
This causes broken styling on Special:MobileOptions and notifications on mobile is inaccessible
Picked up by unit tests on Minerva post merge of T140804
Now blocking all activity inside Minerva.
QA steps
Use beta cluster - verify that notifications is accessible and settings matches https://en.wikipedia.org/wiki/Special:MobileOptions
2:54:54 Time: 3.26 minutes, Memory: 342.97MB
12:54:54
12:54:54 There were 3 errors:
12:54:54
12:54:54 1) /workspace/src/skins/MinervaNeue/skinStyles/mediawiki.page.gallery.styles/tablet.less in the "mediawiki.page.gallery.styles" module
12:54:54 Less_Exception_Compiler: variable @deviceWidthTablet is undefined in file /workspace/src/skins/MinervaNeue/skinStyles/mediawiki.page.gallery.styles/tablet.less in tablet.less on line 5, column 29
12:54:54 3|
12:54:54 4| // Hacks to render galleries and multicol tables better on mobile
12:54:54 5| @media all and ( max-width: @deviceWidthTablet ) {
12:54:54 6|
12:54:54 7| // Center images that might be less than the screen width.
12:54:54 8| // Image will appear centered and caption will take up full screen.
12:54:54
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Variable.php:49
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:52
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Rule.php:75
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Paren.php:32
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:42
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Media.php:57
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php:94
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Parser.php:199
12:54:54 /workspace/src/includes/resourceloader/ResourceLoaderFileModule.php:982
12:54:54 /workspace/src/tests/phpunit/LessFileCompilationTest.php:46
12:54:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
12:54:54 /workspace/src/maintenance/doMaintenance.php:94
12:54:54
12:54:54 2) /workspace/src/skins/MinervaNeue/skinStyles/mobile.special.mobileoptions.styles/minerva.less in the "mobile.special.mobileoptions.styles" module
12:54:54 Less_Exception_Compiler: variable @deviceWidthTablet is undefined in file /workspace/src/skins/MinervaNeue/skinStyles/mobile.special.mobileoptions.styles/minerva.less in minerva.less on line 3, column 29
12:54:54 1| @import '../../minerva.less/minerva.variables';
12:54:54 2|
12:54:54 3| @media all and ( min-width: @deviceWidthTablet ) {
12:54:54 4| .ns-special .pre-content {
12:54:54 5| background: #fff;
12:54:54 6|
12:54:54
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Variable.php:49
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:52
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Rule.php:75
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Paren.php:32
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:42
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Media.php:57
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php:94
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Parser.php:199
12:54:54 /workspace/src/includes/resourceloader/ResourceLoaderFileModule.php:982
12:54:54 /workspace/src/tests/phpunit/LessFileCompilationTest.php:46
12:54:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
12:54:54 /workspace/src/maintenance/doMaintenance.php:94
12:54:54
12:54:54 3) /workspace/src/skins/MinervaNeue/skinStyles/mobile.notifications.overlay/minerva.less in the "mobile.notifications.overlay" module
12:54:54 Less_Exception_Compiler: variable @deviceWidthTablet is undefined in file /workspace/src/skins/MinervaNeue/skinStyles/mobile.notifications.overlay/minerva.less in minerva.less on line 12, column 29
12:54:54 10| }
12:54:54 11|
12:54:54 12| @media all and ( min-width: @deviceWidthTablet ) {
12:54:54 13| .notifications-overlay {
12:54:54 14| .mw-echo-notification {
12:54:54 15| padding: 1.75em @contentPaddingTablet;
12:54:54
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Variable.php:49
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:52
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Rule.php:75
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Paren.php:32
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Expression.php:42
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Value.php:27
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Media.php:57
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php:94
12:54:54 /workspace/src/vendor/oyejorge/less.php/lib/Less/Parser.php:199
12:54:54 /workspace/src/includes/resourceloader/ResourceLoaderFileModule.php:982
12:54:54 /workspace/src/tests/phpunit/LessFileCompilationTest.php:46
12:54:54 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
12:54:54 /workspace/src/maintenance/doMaintenance.php:94
12:54:54
12:54:54 FAILURES!
12:54:54 Tests: 6246, Assertions: 34839, Errors: 3, Skipped: 6.
